Fix issue 1287 bug in subcritical powerplant report method

[Lingyan90]

Fixes

Fix training issue: bug in subcritical powerplant report method #1287.

Also updated the tags units to remove duplicate units in output plant_pdf_results.svg.

Summary/Motivation:

Reproduced the KeyError issue in local machine. The second error regarding solver "IPOPT" was not observed when testing in local machine. This PR helps resolve the KeyError mentioned in the issue.

Changes proposed in this PR:

• Changed the tags method when print_pfd_results.
• Allow tags only when the components is existing in that stream.
• Removed duplicated units in plant_pdf_results.svg.
• Removed incorrect unit conversion of /1000.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

[codecov]

Codecov Report

❌ Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.73%. Comparing base (5a979c4) to head (43c55b0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...subcritical_power_plant/subcritical_power_plant.py	94.11%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1720      +/-   ##
==========================================
+ Coverage   73.67%   73.73%   +0.05%     
==========================================
  Files         398      398              
  Lines       65102    65095       -7     
  Branches    10951    10954       +3     
==========================================
+ Hits        47963    47995      +32     
+ Misses      14632    14592      -40     
- Partials     2507     2508       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dallan-keylogic]

LGTM

Edit: except that the changes aren't being tested. A way you could test these changes is by extracting lines 2211 to 2238 into a helper function that returns the tags and tags_formats dictionaries, then test the outputs of that function.

[dallan-keylogic]

@Lingyan90, can you get to adding tests before the February release?

[Lingyan90]

LGTM

Edit: except that the changes aren't being tested. A way you could test these changes is by extracting lines 2211 to 2238 into a helper function that returns the tags and tags_formats dictionaries, then test the outputs of that function.

The original testing code didn't cover the info from line 2211 to 2238. The exiting testing code is neat and concise. My changes from line 2211 to line 2224 are mainly correct the unit shown in plot plant_pdf_results.svg, and line 2227-2230 for make sure the table report bug got fixed. As those didn't affect the test file, so I didn't make any changes to the test file.

[dallan-keylogic]

The original testing code didn't cover the info from line 2211 to 2238. The exiting testing code is neat and concise. My changes from line 2211 to line 2224 are mainly correct the unit shown in plot plant_pdf_results.svg, and line 2227-2230 for make sure the table report bug got fixed. As those didn't affect the test file, so I didn't make any changes to the test file.

When we fix issues that were not covered by our current tests, we like to write new tests to verify that the functionality does not break in the future. That way we can increase the overall test coverage of the repository.

[ksbeattie]

@Lingyan90 & @dallan-keylogic: does this completely address (meaning close) #1287 ?

[Lingyan90]

@Lingyan90 & @dallan-keylogic: does this completely address (meaning close) #1287 ?

The issue #1287 also mentioned another error (Solver ipopt did not exit normally) that didn't show up in my local machine. Unless anyone see this error in their testing, this current PR completely address #1287.