Resubmitting pull request for new state definition FpTPxpc with testing by tannerpolley · Pull Request #1723 · IDAES/idaes-pse

Created FpTPxpc state definition file

tannerpolley

committed

Created FpTPxpc state definition test files for normal and electrolytes versions

tannerpolley

committed

Altered `b.component_in_phase` methods due to bug where it was not finding the property

tannerpolley

committed

Adding bounds and initialization for various phase equilibrium variables

tannerpolley

committed

Revise the display variables to the appropriate state variables

tannerpolley

committed

Add the configuration file for the BT_Ideal test for the FpTPxpc state definition

tannerpolley

committed

Add the test file for the FpTPxpc state definition on the BT_Ideal case test. Uses a FeedFlash unit model rather than a state block to perform the test

tannerpolley

committed

Ran Black

tannerpolley

committed

Fixed `test_define_display_vars`

tannerpolley

committed

Fixed pylint issues

tannerpolley

committed

Fixed pylint issues

tannerpolley

committed

Revised author names, removed unnecessary tests, and removed a redundant config properties dictionary and file

tannerpolley

committed

Ran Black

tannerpolley

committed

Changes to creation of variable `_teq` and constraint 'equilibrium_constraint' based on `has_phase_equilibrium` boolean. Also additional conditional in blocking the activiation of the `equilibrium_…

tannerpolley

committed

Updated 'phase_frac_constraint' name to match where it is used elsewhere

tannerpolley

committed

Ran black and reverted some changes that caused errors. Pushes these changes to a future potential feature

tannerpolley

committed

Reverted `generic_property.py` to the main branch state since the changes were not passing tests and the changes are not necessary for anything. Maybe a potential future feature

tannerpolley

committed

Reverted `generic_property.py` to the main branch state since the changes were not passing tests and the changes are not necessary for anything. Maybe a potential future feature

tannerpolley

committed

Ran black

tannerpolley

committed

Ran black

tannerpolley

committed

Ran black

tannerpolley

committed

Ran black

tannerpolley

committed

Ran black

tannerpolley

committed

Ran black

tannerpolley

committed

Ran black

tannerpolley

committed

Trigger CI

tannerpolley

committed

Inserted temperature bounds back into `_teq` to prevent evaluation errors

tannerpolley

committed

Uncommented section for testing phase equilibrium initializer object and removed print statements from electrolyte test

tannerpolley

committed

Actually needed to change the number of asserted residuals to 2 rather than 4 for this state definition

tannerpolley

committed

Removed last unnecessary print statements

tannerpolley

committed

legacy scaling Pressure sweep was failing with new Pyomo version on linux versions 3.12 and 3.13 so added the less strict complementarity conditions from the scaler object version to the legacy sca…

tannerpolley

committed

Black

tannerpolley

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Resubmitting pull request for new state definition FpTPxpc with testing#1723

Resubmitting pull request for new state definition FpTPxpc with testing#1723
tannerpolley wants to merge 32 commits intoIDAES:mainfrom
tannerpolley:tanner/FpTPxpc

Commits on Feb 21, 2026

Created FpTPxpc state definition file

Created FpTPxpc state definition test files for normal and electrolytes versions

Altered `b.component_in_phase` methods due to bug where it was not finding the property

Adding bounds and initialization for various phase equilibrium variables

Revise the display variables to the appropriate state variables

Add the configuration file for the BT_Ideal test for the FpTPxpc state definition

Add the test file for the FpTPxpc state definition on the BT_Ideal case test. Uses a FeedFlash unit model rather than a state block to perform the test

Ran Black

Fixed `test_define_display_vars`

Fixed pylint issues

Fixed pylint issues

Revised author names, removed unnecessary tests, and removed a redundant config properties dictionary and file

Ran Black

Changes to creation of variable `_teq` and constraint 'equilibrium_constraint' based on `has_phase_equilibrium` boolean. Also additional conditional in blocking the activiation of the `equilibrium_…

Updated 'phase_frac_constraint' name to match where it is used elsewhere

Ran black and reverted some changes that caused errors. Pushes these changes to a future potential feature

Reverted `generic_property.py` to the main branch state since the changes were not passing tests and the changes are not necessary for anything. Maybe a potential future feature

Reverted `generic_property.py` to the main branch state since the changes were not passing tests and the changes are not necessary for anything. Maybe a potential future feature

Ran black

Ran black

Ran black

Ran black

Ran black

Ran black

Ran black

Trigger CI

Inserted temperature bounds back into `_teq` to prevent evaluation errors

Uncommented section for testing phase equilibrium initializer object and removed print statements from electrolyte test

Actually needed to change the number of asserted residuals to 2 rather than 4 for this state definition

Removed last unnecessary print statements

legacy scaling Pressure sweep was failing with new Pyomo version on linux versions 3.12 and 3.13 so added the less strict complementarity conditions from the scaler object version to the legacy sca…

Black