Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 0 additions & 1 deletion .github/actions/run-examples/examples_for_idaes_ci.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
from idaes_examples import notebooks
from idaes_examples import build


matchmarker = pytest.StashKey()
marked = pytest.StashKey()

Expand Down
1 change: 0 additions & 1 deletion .pylint/idaes_transform.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
import pylint
from astroid.builder import extract_node, parse


_logger = logging.getLogger("pylint.ideas_plugin")


Expand Down
1 change: 1 addition & 0 deletions docs/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"""
Run all build steps for IDAES documentation.
"""

# standard library
import argparse
import glob
Expand Down
1 change: 1 addition & 0 deletions idaes/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

Set up logging for the idaes module, and import plugins.
"""

# TODO: Missing doc strings
# pylint: disable=missing-class-docstring
# pylint: disable=missing-function-docstring
Expand Down
3 changes: 1 addition & 2 deletions idaes/apps/caprese/categorize.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@
# All rights reserved. Please see the files COPYRIGHT.md and LICENSE.md
# for full copyright and license information.
#################################################################################
""" Functions for categorizing variable into e.g. differential and algebraic.
"""
"""Functions for categorizing variable into e.g. differential and algebraic."""

from pyomo.environ import (
Reference,
Expand Down
1 change: 1 addition & 0 deletions idaes/apps/caprese/common/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"""
A module of functions and classes for configuring NMPC/MHE problems
"""

import enum
from pyomo.environ import SolverFactory
from pyomo.core.base.var import VarData
Expand Down
3 changes: 1 addition & 2 deletions idaes/apps/caprese/controller.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@
# All rights reserved. Please see the files COPYRIGHT.md and LICENSE.md
# for full copyright and license information.
#################################################################################
""" Block-like object meant for controller models.
"""
"""Block-like object meant for controller models."""

from idaes.apps.caprese.common.config import (
ControlPenaltyType,
Expand Down
2 changes: 1 addition & 1 deletion idaes/apps/caprese/dynamic_block.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# All rights reserved. Please see the files COPYRIGHT.md and LICENSE.md
# for full copyright and license information.
#################################################################################
""" Block-like object meant for models where almost everything is indexed
"""Block-like object meant for models where almost everything is indexed
by time.
"""

Expand Down
1 change: 1 addition & 0 deletions idaes/apps/caprese/examples/cstr_nmpc.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"""
Example for Caprese's module for NMPC.
"""

import random
from idaes.apps.caprese.nmpc import NMPCSim
from idaes.apps.caprese.util import apply_noise_with_bounds
Expand Down
1 change: 1 addition & 0 deletions idaes/apps/caprese/examples/cstr_reduced.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"""
Example for Caprese's module for NMPC.
"""

import random
from idaes.apps.caprese.nmpc import NMPCSim
from idaes.apps.caprese.dynamic_block import DynamicBlock
Expand Down
2 changes: 1 addition & 1 deletion idaes/apps/caprese/nmpc_var.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# All rights reserved. Please see the files COPYRIGHT.md and LICENSE.md
# for full copyright and license information.
#################################################################################
""" Variable classes for time-indexed variables that can be treated specially
"""Variable classes for time-indexed variables that can be treated specially
by NMPC.
"""

Expand Down
3 changes: 1 addition & 2 deletions idaes/apps/caprese/rolling.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@
# All rights reserved. Please see the files COPYRIGHT.md and LICENSE.md
# for full copyright and license information.
#################################################################################
""" Classes used for rolling-horizon simulation.
"""
"""Classes used for rolling-horizon simulation."""

from pyomo.core.base.componentuid import ComponentUID
from collections import OrderedDict
Expand Down
3 changes: 1 addition & 2 deletions idaes/apps/caprese/tests/test_controller.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@
# All rights reserved. Please see the files COPYRIGHT.md and LICENSE.md
# for full copyright and license information.
#################################################################################
""" Tests for the controller model subclass of block
"""
"""Tests for the controller model subclass of block"""

import pytest
import pyomo.environ as pyo
Expand Down
3 changes: 1 addition & 2 deletions idaes/apps/caprese/tests/test_dynamic_block.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@
# All rights reserved. Please see the files COPYRIGHT.md and LICENSE.md
# for full copyright and license information.
#################################################################################
""" Tests for the dynamic model subclass of block
"""
"""Tests for the dynamic model subclass of block"""

import pyomo.environ as pyo
from pyomo.common.collections import ComponentSet
Expand Down
3 changes: 1 addition & 2 deletions idaes/apps/caprese/tests/test_nmpc_var.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@
# All rights reserved. Please see the files COPYRIGHT.md and LICENSE.md
# for full copyright and license information.
#################################################################################
""" Tests for subclasses of Var
"""
"""Tests for subclasses of Var"""

import pyomo.environ as pyo
from idaes.apps.caprese.nmpc_var import (
Expand Down
3 changes: 1 addition & 2 deletions idaes/apps/caprese/tests/test_rolling.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@
# All rights reserved. Please see the files COPYRIGHT.md and LICENSE.md
# for full copyright and license information.
#################################################################################
""" Tests for rolling horizon helper classes
"""
"""Tests for rolling horizon helper classes"""

import pytest
import sys
Expand Down
1 change: 1 addition & 0 deletions idaes/apps/caprese/tests/test_util.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"""
Tests for Caprese helper utility functions.
"""

import pytest
from pytest import approx

Expand Down
1 change: 0 additions & 1 deletion idaes/apps/grid_integration/examples/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

import pandas as pd


with resources.as_file(
resources.files("idaes.tests.prescient.5bus").joinpath("__init__.py")
) as pkg_file:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# for full copyright and license information.
#################################################################################

"""Tests for `MultiPeriodModel` class """
"""Tests for `MultiPeriodModel` class"""

__author__ = "Radhakrishna Tumbalam Gooty"

Expand Down
1 change: 1 addition & 0 deletions idaes/apps/matopt/materials/parsers/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,5 @@
import matopt.materials.parsers.POSCAR
import matopt.materials.parsers.XYZ
"""

# TODO: Decide if this is necessary
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
The example model is from the IDAES tutorial,
https://github.com/IDAES/examples-pse/blob/main/src/Tutorials/Advanced/ParamEst/
"""

from idaes.core import FlowsheetBlock
from idaes.models.unit_models import Flash
from idaes.models.properties.activity_coeff_models.BTX_activity_coeff_VLE import (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,11 @@
# for full copyright and license information.
#################################################################################
"""
Rooney Biegler model, based on Rooney, W. C. and Biegler, L. T. (2001). Design for
model parameter uncertainty using nonlinear confidence regions. AIChE Journal,
Rooney Biegler model, based on Rooney, W. C. and Biegler, L. T. (2001). Design for
model parameter uncertainty using nonlinear confidence regions. AIChE Journal,
47(8), 1794-1804.
"""

import pandas as pd
import pyomo.environ as pyo

Expand Down
12 changes: 4 additions & 8 deletions idaes/apps/uncertainty_propagation/uncertainties.py
Original file line number Diff line number Diff line change
Expand Up @@ -303,16 +303,12 @@ def propagate_uncertainty(
raise ValueError("cov must be square")

if cov_.shape[0] != len(theta_names):
raise ValueError(
"""cov must be a n x n matrix or dataframe where
n = len(theta_names)"""
)
raise ValueError("""cov must be a n x n matrix or dataframe where
n = len(theta_names)""")

if len(theta_names) != len(theta):
raise ValueError(
"""theta_names and theta must have the same number
of elements"""
)
raise ValueError("""theta_names and theta must have the same number
of elements""")

# Remove all "'" in theta_names
theta_names, var_dic, variable_clean = clean_variable_name(theta_names)
Expand Down
7 changes: 3 additions & 4 deletions idaes/commands/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"""
Base command for 'idaes' commandline script
"""

# TODO: Missing docstrings
# pylint: disable=missing-function-docstring

Expand Down Expand Up @@ -91,8 +92,7 @@ def command_base(verbose, quiet):

@command_base.command(help="Show IDAES copyright information")
def copyright(): # pylint: disable=W0622
click.echo(
"""
click.echo("""
================================================================================
Institute for the Design of Advanced Energy Systems Process Systems
Engineering Framework (IDAES PSE Framework) Copyright (c) 2018-2019, by the
Expand All @@ -104,8 +104,7 @@ def copyright(): # pylint: disable=W0622
license information, respectively. Both files are also available online
at the URL "https://github.com/IDAES/idaes-pse".
================================================================================
"""
)
""")


@command_base.command(help="Show how long it takes to import command modules")
Expand Down
1 change: 1 addition & 0 deletions idaes/commands/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
# for full copyright and license information.
#################################################################################
"""Commandline Utilities for Managing the IDAES Config files"""

# TODO: Missing docstrings
# pylint: disable=missing-function-docstring

Expand Down
1 change: 1 addition & 0 deletions idaes/commands/convergence.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
# for full copyright and license information.
#################################################################################
"""Commandline interface for convergence testing tools"""

# This code is deprecated
# pylint: disable=missing-function-docstring

Expand Down
1 change: 1 addition & 0 deletions idaes/commands/data_directory.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
# for full copyright and license information.
#################################################################################
"""Commandline Utilities for Managing the IDAES Data Directory"""

# TODO: Missing docstrings
# pylint: disable=missing-function-docstring

Expand Down
4 changes: 2 additions & 2 deletions idaes/commands/env_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
# All rights reserved. Please see the files COPYRIGHT.md and LICENSE.md
# for full copyright and license information.
#################################################################################
"""Get info about the environment IDAES is running in and the IDAES version
"""
"""Get info about the environment IDAES is running in and the IDAES version"""

# TODO: Missing docstrings
# pylint: disable=missing-function-docstring

Expand Down
1 change: 1 addition & 0 deletions idaes/commands/examples.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"""
Install IDAES example files locally.
"""

import sys

# third-party
Expand Down
1 change: 1 addition & 0 deletions idaes/commands/extensions.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
# for full copyright and license information.
#################################################################################
"""Commandline Utilities for Managing the IDAES Data Directory"""

# TODO: Missing docstrings
# pylint: disable=missing-function-docstring

Expand Down
1 change: 1 addition & 0 deletions idaes/commands/tests/test_commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"""
Tests for idaes.commands
"""

# stdlib
from functools import partial
import json
Expand Down
1 change: 0 additions & 1 deletion idaes/commands/util/tests/test_download_bin.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
import idaes.logger as idaeslog
import idaes.config as idaes_config


_log = idaeslog.getLogger(__name__)


Expand Down
2 changes: 1 addition & 1 deletion idaes/core/base/components.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

@author: alee
"""

# TODO: Missing docstrings
# pylint: disable=missing-function-docstring

Expand All @@ -27,7 +28,6 @@
from idaes.core.util.misc import set_param_from_config
import idaes.logger as idaeslog


# Set up logger
_log = idaeslog.getLogger(__name__)

Expand Down
1 change: 1 addition & 0 deletions idaes/core/base/control_volume0d.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"""
Base class for control volumes.
"""

# TODO: Missing docstrings
# pylint: disable=missing-function-docstring

Expand Down
7 changes: 3 additions & 4 deletions idaes/core/base/control_volume1d.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"""
Base class for control volumes
"""

# TODO: Missing docstrings
# pylint: disable=missing-function-docstring

Expand Down Expand Up @@ -2422,12 +2423,10 @@ def report(self, time_point=0, dof=False, ostream=None, prefix=""):
difficulty of presenting spatially discretized data in a readable form
without plotting.
"""
raise NotImplementedError(
"""
raise NotImplementedError("""
Due to the difficulty in presenting spatially distributed data
in a clean format, ControlVolume1D does not currently support
the report method."""
)
the report method.""")

def calculate_scaling_factors(self):
super().calculate_scaling_factors()
Expand Down
2 changes: 1 addition & 1 deletion idaes/core/base/costing_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"""
Base classes for process costing
"""

# TODO: Missing docstrings
# pylint: disable=missing-function-docstring

Expand All @@ -33,7 +34,6 @@

import idaes.logger as idaeslog


# Set up logger
_log = idaeslog.getLogger(__name__)

Expand Down
1 change: 1 addition & 0 deletions idaes/core/base/flowsheet_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
This module contains the base class for constructing flowsheet models in the
IDAES modeling framework.
"""

# TODO: Missing docstrings
# pylint: disable=missing-function-docstring
from warnings import warn
Expand Down
1 change: 1 addition & 0 deletions idaes/core/base/phases.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

@author: alee
"""

# TODO: Missing docstrings
# pylint: disable=missing-function-docstring

Expand Down
Loading
Loading