Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1734 +/- ##
==========================================
+ Coverage 73.73% 73.76% +0.03%
==========================================
Files 398 398
Lines 65095 65208 +113
Branches 10954 10985 +31
==========================================
+ Hits 47995 48099 +104
- Misses 14592 14598 +6
- Partials 2508 2511 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
I ended up creating a handful of utility functions for work in PrOMMiS that fit better in IDAES. This PR brings them in, as well as adds testing.
scale_time_discretization_equationsis a function for scalingDerivativeVarsand discretization equations en masse. This function existed for the old scaling tools, but this version is updated to not useconstraint_scaling_transform.copy_values_from_pointis a generalization of a function I was using to copy the steady-state values from t=0 forward to other time points.assert_solution_equivalentis a way to compare the solution of a model to a cached version. We would typically compare values variable-by-variable. However, that means we only see the values that changed one at a time. In order to see what else has changed, we have to run the test again or look forward in the tests checking value by value manually. This function compares all values, generates a report about which variables have changed more than their tolerances, then raises anAssertionErrorat the end if there are variables who changed outside their tolerances.Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: