Skip to content

Update get-extensions and setup-environment logic for new major release of extensions - #1768

Open
mrmundt wants to merge 53 commits into
IDAES:mainfrom
mrmundt:new-idaes-ext
Open

Update get-extensions and setup-environment logic for new major release of extensions#1768
mrmundt wants to merge 53 commits into
IDAES:mainfrom
mrmundt:new-idaes-ext

Conversation

@mrmundt

@mrmundt mrmundt commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Fixes #1248, #1583 , #1562 , #1536, IDAES/idaes-ext#274

Summary/Motivation:

Who wants new extension versions?

WE DO!

This PR implements the changes necessary to support both old and new versions of IDAES extensions in a lovely, compatible way. There are probably a plethora of opportunities for debate on exact implementations, so go forth and argue.

That being said, this does currently work for both <4 and >=4 releases. NOTE that I know there are some failing tests, and I am going to need some guidance/help on how to fix them. I wanted this open for the visibility of those and to enable discussion.

Changes proposed in this PR:

  • Update supported OS' map
  • Make failure messages a bit stronger
  • No longer assume that all of the executables and libraries are in bin_directory; be more layout/release aware
  • Add in functionality to parse old and new license/version info files
  • Add in functionality to setup the environment correctly on all OS' for both old and new layout structures
  • Warn if someone is trying to install >= 4 release stuff but they still have < 4 items in their IDAES path
  • Make petsc-finding logic compatible for both old and new layouts
  • Tests tests tests

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov

codecov Bot commented Apr 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.06250% with 69 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.98%. Comparing base (a60fbf8) to head (b0b9fb5).

Files with missing lines Patch % Lines
idaes/commands/extensions.py 40.00% 29 Missing and 4 partials ⚠️
idaes/__init__.py 0.00% 13 Missing ⚠️
idaes/commands/util/download_bin.py 79.31% 8 Missing and 4 partials ⚠️
idaes/config.py 70.00% 8 Missing and 1 partial ⚠️
idaes/core/solvers/petsc.py 87.50% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1768      +/-   ##
==========================================
- Coverage   77.56%   73.98%   -3.58%     
==========================================
  Files         423      423              
  Lines       67529    67648     +119     
  Branches    11420    11465      +45     
==========================================
- Hits        52379    50052    -2327     
- Misses      12531    14972    +2441     
- Partials     2619     2624       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Apr 16, 2026
@ksbeattie

Copy link
Copy Markdown
Member

@mrmundt is this (and the idaes-ext release) still looking possible for a May (end of the month) release?

@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Jul 22, 2026
@dallan-keylogic dallan-keylogic added the CI:run-integration triggers_workflow: Integration label Jul 22, 2026
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Jul 22, 2026
@dallan-keylogic dallan-keylogic added the CI:run-integration triggers_workflow: Integration label Jul 22, 2026
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Jul 22, 2026
@dallan-keylogic dallan-keylogic mentioned this pull request Jul 23, 2026
@mrmundt mrmundt added the CI:run-integration triggers_workflow: Integration label Jul 23, 2026
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Jul 23, 2026
@mrmundt mrmundt added the CI:run-integration triggers_workflow: Integration label Jul 24, 2026
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Jul 24, 2026
@mrmundt mrmundt added the CI:run-integration triggers_workflow: Integration label Jul 24, 2026
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Jul 24, 2026
@mrmundt mrmundt added the CI:run-integration triggers_workflow: Integration label Jul 24, 2026
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Jul 24, 2026
@mrmundt mrmundt added the CI:run-integration triggers_workflow: Integration label Jul 24, 2026
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Jul 24, 2026
@mrmundt mrmundt added the CI:run-integration triggers_workflow: Integration label Jul 24, 2026
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Jul 24, 2026
@ksbeattie

Copy link
Copy Markdown
Member

Waiting on funding to arrive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update IPOPT version to 3.14

4 participants