Updates to the ParmEst interface of uncertainty propagation - #1812
Updates to the ParmEst interface of uncertainty propagation#1812slilonfe5 wants to merge 16 commits into
Conversation
|
@blnicho @adowling2 This PR updates the ParmEst interface of the uncertainty propagation (UP) toolbox. The current ParmEst interface is legacy (i.e., pre-experiment list). I updated the UP toolbox to the latest ParmEst interface while allowing backward compatibility. Kindly review. Thank you. Tests are not running, as they require approval from a maintainer |
|
@slilonfe5 I think the spell check is failing because IDAES is pinned to a very old version of the typos workflow (https://github.com/IDAES/idaes-pse/blob/main/.github/workflows/core.yml#L83). I think we should open a separate PR to bump it to the latest version. |
Thanks @blnicho. I don't know how to do this, but if you can guide me on how to update the typos workflow, I can help create the separate PR to fix it. |
|
@slilonfe5 I opened #1813 to update the typos version. You can try merging my branch into your PR to see if that fixes the Spell check issue. |
Great. Thank you @blnicho |
|
@blnicho I have merged your branch into this PR. You can rerun the tests |
|
Looks like it still isn't happy about "Parm". I'm going to add it to the list of typos to ignore and push directly to your branch. |
|
Looks like the compatibility tests are failing everywhere and not caused by your changes. |
Yes. I also observe this. |
|
I was just checking to see if the same tests were failing here as are in my PR. If it's not already known, CoolProp released version 8 recently which I believe is behind the failures... |
|
Hello @blnicho. I'm just checking to see if there are updates on the failing tests which are not related to the PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1812 +/- ##
==========================================
+ Coverage 73.83% 73.84% +0.01%
==========================================
Files 423 423
Lines 67527 67557 +30
Branches 11420 11428 +8
==========================================
+ Hits 49859 49888 +29
Misses 15051 15051
- Partials 2617 2618 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hello @blnicho, I have added three tests to exercise the previously uncovered code to improve coverage. Thanks |
Fixes
This pull request updates the parameter estimation (PE) interface of the uncertainty propagation toolbox
Summary/Motivation:
ParmEst has advanced to using an experiment list for PE, which contains Experiment class objects that contain the labeled Pyomo model and the data. ParmEst also computes the covariance matrix in a separate function. The uncertainty propagation toolbox needs to be updated to capture the new ParmEst interface and capabilities.
Changes proposed in this PR:
quantify_propagate_uncertaintyto capture the new ParmEst interface and featuresquantify_propagate_uncertaintyLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: