Skip to content

Updates to the ParmEst interface of uncertainty propagation - #1812

Open
slilonfe5 wants to merge 16 commits into
IDAES:mainfrom
slilonfe5:update-uncertainty-propagation
Open

Updates to the ParmEst interface of uncertainty propagation#1812
slilonfe5 wants to merge 16 commits into
IDAES:mainfrom
slilonfe5:update-uncertainty-propagation

Conversation

@slilonfe5

Copy link
Copy Markdown

Fixes

This pull request updates the parameter estimation (PE) interface of the uncertainty propagation toolbox

Summary/Motivation:

ParmEst has advanced to using an experiment list for PE, which contains Experiment class objects that contain the labeled Pyomo model and the data. ParmEst also computes the covariance matrix in a separate function. The uncertainty propagation toolbox needs to be updated to capture the new ParmEst interface and capabilities.

Changes proposed in this PR:

  • Update quantify_propagate_uncertainty to capture the new ParmEst interface and features
  • Enable backward-compatibility for the old interface of quantify_propagate_uncertainty

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@slilonfe5
slilonfe5 marked this pull request as ready for review June 30, 2026 15:56
@slilonfe5
slilonfe5 requested a review from adowling2 as a code owner June 30, 2026 15:56
@slilonfe5

slilonfe5 commented Jun 30, 2026

Copy link
Copy Markdown
Author

@blnicho @adowling2 This PR updates the ParmEst interface of the uncertainty propagation (UP) toolbox. The current ParmEst interface is legacy (i.e., pre-experiment list). I updated the UP toolbox to the latest ParmEst interface while allowing backward compatibility.

Kindly review. Thank you. Tests are not running, as they require approval from a maintainer

@blnicho
blnicho self-requested a review June 30, 2026 18:14
@blnicho

blnicho commented Jun 30, 2026

Copy link
Copy Markdown
Member

@slilonfe5 I think the spell check is failing because IDAES is pinned to a very old version of the typos workflow (https://github.com/IDAES/idaes-pse/blob/main/.github/workflows/core.yml#L83). I think we should open a separate PR to bump it to the latest version.

@slilonfe5

Copy link
Copy Markdown
Author

@slilonfe5 I think the spell check is failing because IDAES is pinned to a very old version of the typos workflow (https://github.com/IDAES/idaes-pse/blob/main/.github/workflows/core.yml#L83). I think we should open a separate PR to bump it to the latest version.

Thanks @blnicho. I don't know how to do this, but if you can guide me on how to update the typos workflow, I can help create the separate PR to fix it.

@blnicho

blnicho commented Jun 30, 2026

Copy link
Copy Markdown
Member

@slilonfe5 I opened #1813 to update the typos version. You can try merging my branch into your PR to see if that fixes the Spell check issue.

@slilonfe5

slilonfe5 commented Jun 30, 2026

Copy link
Copy Markdown
Author

@slilonfe5 I opened #1813 to update the typos version. You can try merging my branch into your PR to see if that fixes the Spell check issue.

Great. Thank you @blnicho

@slilonfe5

Copy link
Copy Markdown
Author

@blnicho I have merged your branch into this PR. You can rerun the tests

@blnicho

blnicho commented Jun 30, 2026

Copy link
Copy Markdown
Member

Looks like it still isn't happy about "Parm". I'm going to add it to the list of typos to ignore and push directly to your branch.

@blnicho

blnicho commented Jun 30, 2026

Copy link
Copy Markdown
Member

Looks like the compatibility tests are failing everywhere and not caused by your changes.

@slilonfe5

Copy link
Copy Markdown
Author

Looks like the compatibility tests are failing everywhere and not caused by your changes.

Yes. I also observe this.

@StephenBurroughs

Copy link
Copy Markdown
Contributor

I was just checking to see if the same tests were failing here as are in my PR. If it's not already known, CoolProp released version 8 recently which I believe is behind the failures...

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Jul 2, 2026
@slilonfe5

Copy link
Copy Markdown
Author

Hello @blnicho. I'm just checking to see if there are updates on the failing tests which are not related to the PR.

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.84%. Comparing base (0741120) to head (ea4d132).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...daes/apps/uncertainty_propagation/uncertainties.py 97.14% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1812      +/-   ##
==========================================
+ Coverage   73.83%   73.84%   +0.01%     
==========================================
  Files         423      423              
  Lines       67527    67557      +30     
  Branches    11420    11428       +8     
==========================================
+ Hits        49859    49888      +29     
  Misses      15051    15051              
- Partials     2617     2618       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@slilonfe5

Copy link
Copy Markdown
Author

Hello @blnicho, I have added three tests to exercise the previously uncovered code to improve coverage. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority:Normal Normal Priority Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants