Update to support CoolPropv8 - #1815
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1815 +/- ##
==========================================
- Coverage 73.84% 73.84% -0.01%
==========================================
Files 422 422
Lines 67509 67509
Branches 11417 11417
==========================================
- Hits 49853 49852 -1
- Misses 15039 15040 +1
Partials 2617 2617 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thank you for doing this! |
|
@ksbeattie I've made two changes here. One is to add a check for the version of CoolProp within the CoolPropWrapper test, then check that the thrown error is appropriate based on the version. This should be fine to go in as is given that it has no other change, although the compatibility repository will still need to have that PR merged to make that pass. I'm happy to rollback that change and just go with the error message one if that's preferable for now, but it does raise a bit of conundrum... Given that it seems impractical to have a case-based formulation and the results are still actually quite accurate (tolerance of 1e-6 vs 1e-4), it seems like updating the tolerances is probably the best course of action... |
Fixes
Updates coolprop wrapper tests to expect new assertion error for missing components.
This doesn't fix the compatability test, as it's in a separate repository. I have opened a pull request in that repository to update the tolerance of the haber bosch test which should fix it: https://github.com/IDAES/idaes-compatibility/pull/13
Summary/Motivation:
Coolprop has updated to v8, the only breaking change is that it now returns a different error.
Changes proposed in this PR:
-Fix test
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: