Remove NonNegativeReals from main repo - #1829
Open
dallan-keylogic wants to merge 5 commits into
Open
Conversation
dallan-keylogic
marked this pull request as ready for review
July 31, 2026 19:22
dallan-keylogic
requested review from
MAZamarripa,
agarciadiego,
bpaul4,
ksbeattie and
sufikaur
as code owners
July 31, 2026 19:22
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1829 +/- ##
=======================================
Coverage 77.56% 77.56%
=======================================
Files 423 423
Lines 67529 67529
Branches 11420 11420
=======================================
Hits 52379 52379
Misses 12531 12531
Partials 2619 2619 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
#1795
Summary/Motivation:
The domain
NonNegativeRealsis redundant when bounds are defined and silently truncates user bounds that are lower than zero. In reviewing the repo, I found some modeling mistakes in the enthalpy state variables for the modular properties. The domain was improperly set toNonNegativeReals, and the user would be none the wiser if they used a negative lower bound.Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: