Skip to content

Remove NonNegativeReals from main repo - #1829

Open
dallan-keylogic wants to merge 5 commits into
IDAES:mainfrom
dallan-keylogic:remove_NonNegativeReals
Open

Remove NonNegativeReals from main repo#1829
dallan-keylogic wants to merge 5 commits into
IDAES:mainfrom
dallan-keylogic:remove_NonNegativeReals

Conversation

@dallan-keylogic

Copy link
Copy Markdown
Contributor

Fixes

#1795

Summary/Motivation:

The domain NonNegativeReals is redundant when bounds are defined and silently truncates user bounds that are lower than zero. In reviewing the repo, I found some modeling mistakes in the enthalpy state variables for the modular properties. The domain was improperly set to NonNegativeReals, and the user would be none the wiser if they used a negative lower bound.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@dallan-keylogic
dallan-keylogic marked this pull request as ready for review July 31, 2026 19:22
@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.56%. Comparing base (a60fbf8) to head (176bc19).

Files with missing lines Patch % Lines
idaes/models/costing/SSLW.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1829   +/-   ##
=======================================
  Coverage   77.56%   77.56%           
=======================================
  Files         423      423           
  Lines       67529    67529           
  Branches    11420    11420           
=======================================
  Hits        52379    52379           
  Misses      12531    12531           
  Partials     2619     2619           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant