Open
Conversation
will-moore
reviewed
Mar 23, 2026
scripts/annotate/recache.py
Outdated
| print(f"Error processing object: {e}") | ||
|
|
||
| if args.thumbs: | ||
| objs = get_objects(conn, args.container, img_only=True) |
Member
There was a problem hiding this comment.
You could have added a line here to filter objs for "image" instead of changing your get_objects() function, but either approach is fine so no need to change.
objs = [obj for obj in objs if obj[[1] == "image"]
will-moore
approved these changes
Mar 23, 2026
Member
will-moore
left a comment
will-moore
left a comment
There was a problem hiding this comment.
I've not used recache.py before and I haven't tested it just now but the code changes look fine.
If this is an important part of the IDR workflow, just need to make sure it's documented in the appropriate places. I expect we'll need to overhaul the IDR publishing docs with the migration soon.
Member
Author
|
I've just used for the idr0167 for next release :-) . But indeed, should be better documented, but need overhaul of that anyway after migration. I suspect we still need the (re-)caching workflow on new IDR too. |
Member
|
LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See title.