-
Notifications
You must be signed in to change notification settings - Fork 0
Added dropdown for majors in registration and settings #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…g LEARN MORE button just all lowercase to learn more
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
The white background is completely fine for the majors! I really like the UI you added and it looks very neat |
|
Thank you for writing down all the majors/tracks, however could you exclude the tracks and only include the majors? Because the resume website will eventually have a search filter and I think people should be able to search by major, not major/track combos (unless we do one filter for major, one filter for track) because then you won't be able to see all cpe majors for instance |
|
Additionally, I noticed that when you login and view the settings, the major no longer saves and you are prompted to enter the major again on the settings page. additionally it doesn't update the database properly, and the database will just show the initial major you input as! |
morallyearlgrey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check comments on conversation page 🫡
|
Removed tracks from majors. Possibly fixed database not getting major. Don't have access to db to properly test. |
|
Having deployment issues because max branches reached </3 but I added:
|
|
This looks like it will have a lot of merge conflicts with some of the recent /dev branch. I know some of that will be from my updates to implement secure middleware. There are also commits to add extra files that have been already implemented. Most of the merge conflicts look more along spacing and just being a bit out of sync. @morallyearlgrey do you know if the new enums added to the database structure, or do I need to get that to Thandi or update it on Neon? |
Formatting of the dropdown is a little weird because some of the majors listed are really long. Currently on white background because I could not get the text to change to white.