Skip to content

Conversation

@Spellpunk101
Copy link
Contributor

Formatting of the dropdown is a little weird because some of the majors listed are really long. Currently on white background because I could not get the text to change to white.

@vercel
Copy link

vercel bot commented Nov 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ieee-website Ready Ready Preview Comment Nov 19, 2025 11:03pm

@morallyearlgrey morallyearlgrey self-requested a review November 19, 2025 06:12
@morallyearlgrey
Copy link
Collaborator

The white background is completely fine for the majors! I really like the UI you added and it looks very neat

@morallyearlgrey
Copy link
Collaborator

Thank you for writing down all the majors/tracks, however could you exclude the tracks and only include the majors? Because the resume website will eventually have a search filter and I think people should be able to search by major, not major/track combos (unless we do one filter for major, one filter for track) because then you won't be able to see all cpe majors for instance

@morallyearlgrey
Copy link
Collaborator

Additionally, I noticed that when you login and view the settings, the major no longer saves and you are prompted to enter the major again on the settings page. additionally it doesn't update the database properly, and the database will just show the initial major you input as!

Copy link
Collaborator

@morallyearlgrey morallyearlgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check comments on conversation page 🫡

@Spellpunk101
Copy link
Contributor Author

Removed tracks from majors. Possibly fixed database not getting major. Don't have access to db to properly test.

@morallyearlgrey
Copy link
Collaborator

Having deployment issues because max branches reached </3 but I added:

  • Fixed the major dropdown to properly reflect in the database and be saved
  • Edited settings to correctly display all new member information once it's saved
  • Made some settings information not optional
  • [FUTURE ADDITION] Add error toasts for settings information

@MsMarion
Copy link

This looks like it will have a lot of merge conflicts with some of the recent /dev branch. I know some of that will be from my updates to implement secure middleware. There are also commits to add extra files that have been already implemented. Most of the merge conflicts look more along spacing and just being a bit out of sync. @morallyearlgrey do you know if the new enums added to the database structure, or do I need to get that to Thandi or update it on Neon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants