-
Notifications
You must be signed in to change notification settings - Fork 65
Capture Information Block (CIB) addition #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Capture Information Block (CIB) addition #183
Conversation
|
Presumably multiple CIBs can be provided for the same interface if the interface is in motion. |
| : The cib_orientation option specifies the orientation of the packet | ||
| capturing antenna; orientation is stored as three 32-bit floats | ||
| representing yaw, pitch, and roll in radians. | ||
| This is relative to the zero frame for global or local location. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The zero frame for global location is presumably the frame whose origin is at the intersection of the IERS Reference Meridian and the Equator, at an altitude that's relative to some reference point at that location (mean sea level, which would make it height above mean sea level?).
The plane for local location is presumably a plane tangent to the Earth's surface at some point; is that a fixed point, or could it move relative to the origin of the zero frame for global location?
23e739f to
d1fd806
Compare
Yes. Two paragraphs relevant to this:
The second paragraph is a bit conflicting for me. I understand this may be done because updating location and not updating positioning error it may be very common but this may also cause errors... What do you think? |
Presumably the options are cleared because in case an update removes an option, as a CIB just has a list of options, not a list of changes to the options including "add", "change", and "remove". IDBs could also use a mechanism to allow options to be added, removed, or changed options might be useful.
Errors as in "a second CIB might forget to include options that aren't getting changed"? |
Agree although for my particular usecase both options would fit.
Yes, I was thinking about that. Maybe today, after rethinking about it, it seems not that important. Do we agree on keeping the existing mechanism and not changing it to a an "add", "change" or "remove" one? |
Given that this was a doubt I raised myself and that you did not show support for it, I guess we have an agreement for the time being and I will keep on going with the next comments/questions. Thanks! |
|
|
||
| Location information can be represented with in global (lat/lng/alt in degrees) | ||
| or local (X/Y/Z in metres) form, only one of these forms may be used in a given PCAP file. | ||
| Combining pcap files with different location formats should result in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like some imput regarding this one. If both Global and Local location information is used in the same pcap files it should result in the removal of all position information: Would it make sense to include a global location information to tag the specific pcap in a global position and then start using local coordinates referencing this origin? Does this make sense for any usecase? Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to use global + local positioning in a case where you are performing a capture in a reference frame that is moving on which you would like to have local measurements of high precission? Example: Performing captures on a train where local frame would map the interior of the train but global one would position the train globally? 🤔
Following #51, this is simply a rebase of the original PR.