Skip to content

Conversation

@kbirken
Copy link
Member

@kbirken kbirken commented Apr 10, 2025

This solves #1292. The missing test language o.i.core.trace.test is deployed now in the org.iets3.core.trace.test plugin.

Questions for the reviewers:

  • Why do we deploy the test solutions at all?
  • Could it be a problem if we now deploy an additional language for the tests?

@kbirken kbirken requested review from arimer and wsafonov as code owners April 10, 2025 17:30
@kbirken kbirken self-assigned this Apr 10, 2025
Copy link
Member

@alexanderpann alexanderpann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, thanks for the fix. Regarding why tests are published: @sergej-koscejev wrote this back in the days, so he might have an answer to that.

@kbirken kbirken merged commit 4b28307 into maintenance/mps20241 Apr 14, 2025
2 checks passed
@kbirken kbirken deleted the bugfix/add_trace_testlang_to_deployment_1292 branch April 14, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants