Bundled deps as provided in pom #1507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly specifying the type of the takari-cpsuite dependency makes it unnecessary to override its jar name.
sergej-koscejev
requested review from
arimer and
jonaskraemer
as code owners
Member
|
The build never got picked up by TC due to the branch name.. I triggered it |
arimer
approved these changes
Nov 18, 2025
Member
arimer
left a comment
arimer
left a comment
There was a problem hiding this comment.
Changes look good.
The created pom files now contain version informations like:
dependency>
<groupId>org.pcollections</groupId>
<artifactId>pcollections</artifactId>
<version>4.0.2</version>
<type>jar</type>
<scope>provided</scope>
</dependency>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jarNameOverride, specify the type of takari-cpsuite artifact explicitly.