Remove invalid checking rule for functional components #1528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…components (issue #1527).
kbirken
requested review from
mfsoliveira
and removed request for
arimer and
jonaskraemer
mfsoliveira
approved these changes
Nov 28, 2025
Member
mfsoliveira
left a comment
mfsoliveira
left a comment
There was a problem hiding this comment.
Check and Test were removed.
Change log updated.
Looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checking rule was introduced in February 2025 by a move from IETS3.Core. It was probably never used before, but after the move it induces model check errors in IETS3.Core (in Simbench models and others). See ticket #1527 for details.
CHANGELOG has been updated accordingly.
This solves #1527.