Variability: Provide inspector editor for FeatureAttributeAssignment #1564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfsoliveira
approved these changes
Dec 12, 2025
Member
mfsoliveira
left a comment
mfsoliveira
left a comment
There was a problem hiding this comment.
Yes. I thought we could use hints.
I have created it in core, but it was not really used, because it is called from the table creation code. we can clean it by now in core.
The changes look fine.
I updated the testing label used in the failing test. Now it should work fine too.
kbirken
deleted the
feature/inspector_for_featureattributeassignment_1563
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a restriction of the slisson-tables gridquery, for a cell in the table always the standard inspector is shown (the inspector does not respect context hints). Thus, we have to provide an standard inspector editor definition for
FeatureAttributeAssignmentnodes to be able to show it in the inspector of the configuration matrix (and similar editors).For the normal variant configuration editor, this will do no harm.
No CHANGELOG addition as this is a purely technical extension which will not be visible to the user of IETS3.Opensource.
This solves #1563.