Creating EvaluatorBase #257
Conversation
api/rda.py
Outdated
| ids = [item_id] | ||
|
|
||
| # FIXME oai-pmh should be no different | ||
| downstream_logger = evaluator.logger |
There was a problem hiding this comment.
downstream_logger = None (evaluator is not set)
|
Added changes to adapt EPOS plugin to |
ferag
left a comment
ferag
left a comment
There was a problem hiding this comment.
Where the list of config params should be loaded?
| ) | ||
| self.internet_media_types_path = ast.literal_eval( | ||
| self.config["internet media types"]["path"] | ||
| ) |
There was a problem hiding this comment.
The config loading is already included in EvalutorBase. Do you think it is better to trust in super() class or we should keep this loading on each plugins?
There was a problem hiding this comment.
yes, it makes sense to use super(). . I'll make the change
There was a problem hiding this comment.
Commit 00fa1c89dc0553d91cf468d486ac00f7c278ebed allows to pass (*args, **kwargs) from the Plugin class so you don't need to provide the list of input args to super(). In case you want to apply it to other plugins.
|
@ferag |
Do you think is it OK to use a general "api_endpoint" variable? |
sure. Last commit address this, but not tested all the plugins |
No description provided.