Skip to content

Comments

Move usage of Geocoder in MontyGeoCoder#223

Merged
tnagorra merged 4 commits intodevelopfrom
fix/geocoder-usage
Mar 22, 2025
Merged

Move usage of Geocoder in MontyGeoCoder#223
tnagorra merged 4 commits intodevelopfrom
fix/geocoder-usage

Conversation

@tnagorra
Copy link
Member

@tnagorra tnagorra commented Mar 20, 2025

Depends on IFRCGo/pystac-monty#48

Changes

  • Move usage of Geocoder in MontyGeoCoder
  • Refactor models for ETL
  • Use TypedDict for IFRCEvent params
  • Create abstract model Tracing
  • Update admin panel settings for ETL
  • Remove validate_source_func
  • Update use of library ee (pyright not reading re-exports)

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests

@tnagorra tnagorra requested review from Rup-Narayan-Rajbanshi, sudan45 and thenav56 and removed request for Rup-Narayan-Rajbanshi March 20, 2025 17:04
@tnagorra tnagorra force-pushed the fix/geocoder-usage branch from f1e107e to a0b979a Compare March 20, 2025 17:36
- Refactor models for ETL
- Use TypedDict for IFRCEvent params
- Create abstract model Tracing
- Update admin panel settings for ETL
- Remove validate_source_func
- Update use of library ee (pyright not reading re-exports)
@tnagorra tnagorra force-pushed the fix/geocoder-usage branch from a0b979a to d8c1e4d Compare March 22, 2025 06:25
@tnagorra tnagorra marked this pull request as ready for review March 22, 2025 06:25
@tnagorra tnagorra force-pushed the fix/geocoder-usage branch from d10f050 to 0e4dec8 Compare March 22, 2025 11:24
@tnagorra tnagorra merged commit 7b22e59 into develop Mar 22, 2025
2 of 3 checks passed
@tnagorra tnagorra deleted the fix/geocoder-usage branch March 22, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant