Closed
Conversation
Contributor
ranjan-stha
commented
Mar 19, 2025
ranjan-stha
commented
- Check few USGS fields
- Set the country_codes to be Unknown (UNK) as the method to get the iso3 from geometry is not implemented. Will have to look into this later.
Arrange the import
ranjan-stha
requested review from
Rup-Narayan-Rajbanshi
and removed request for
Rup-Narayan-Rajbanshi
tnagorra
reviewed
Mar 20, 2025
tnagorra
reviewed
Mar 20, 2025
| raise NotImplementedError("Method not implemented") | ||
|
|
||
| def get_geometry_from_iso3(self, iso3: str) -> Optional[Dict[str, Any]]: | ||
| if not self.gpkg_path and self.service_base_url: |
Collaborator
There was a problem hiding this comment.
Why dont have the world boundaries doing that instead of going on internet?
Member
There was a problem hiding this comment.
We are using https://github.com/IFRCGo/geocoding-service
Member
|
Closing in favor of https://github.com/IFRCGo/pystac-monty/pull/61/files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.