Fix ibtracs collection id and country code.#47
Closed
Rup-Narayan-Rajbanshi wants to merge 1 commit intomainfrom
Closed
Fix ibtracs collection id and country code.#47Rup-Narayan-Rajbanshi wants to merge 1 commit intomainfrom
Rup-Narayan-Rajbanshi wants to merge 1 commit intomainfrom
Conversation
Rup-Narayan-Rajbanshi
force-pushed
the
fix/ibtracs-collection-id
branch
from
79e930a to
c2ed5ee
Compare
pystac_monty/sources/ibtracs.py
Outdated
| for point in track_geometry.coords: | ||
| lon, lat = point | ||
| country_code = self.geocoder.get_iso3_from_geometry(Point(lon, lat)) | ||
| # country_code = self.geocoder.get_iso3_from_geometry(Point(lon, lat)) |
Collaborator
There was a problem hiding this comment.
why is the geocoding removed?
Contributor
Author
There was a problem hiding this comment.
@emmanuelmathot this method is not implemented in our Geocoding. So for quick fix, we are passing UNK (Unknown) for now.
Collaborator
There was a problem hiding this comment.
I'd rather prefer the geocoding to return 'UNK' then. I am using a geocoder that implement the function and I need the items to be properly labelled
Rup-Narayan-Rajbanshi
force-pushed
the
fix/ibtracs-collection-id
branch
from
c2ed5ee to
30c6455
Compare
ranjan-stha
approved these changes
Mar 23, 2025
Rup-Narayan-Rajbanshi
force-pushed
the
fix/ibtracs-collection-id
branch
from
30c6455 to
5fdfcc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes