Skip to content

Update ios.yml with new device and OS version #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 2, 2025
Merged

Update ios.yml with new device and OS version #308

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9d98008
Update ios.yml with new device and OS version
alexianunez Apr 2, 2025
642988f
using latest flag instead of specific iOS version
alexianunez Apr 2, 2025
658b0b6
Updated iOS.yml that uses latest OS / device version
alexianunez Apr 2, 2025
06daa85
using first device instead of getting latest runtime + device
alexianunez Apr 2, 2025
d709049
trying this...
alexianunez Apr 2, 2025
aa3dcf1
typo
alexianunez Apr 2, 2025
8852749
undoing last change
alexianunez Apr 2, 2025
a850d75
remove OS
alexianunez Apr 2, 2025
dcb94e4
hard-coding device name
alexianunez Apr 2, 2025
943c738
escaped regex
alexianunez Apr 2, 2025
5b5ae78
another regex
alexianunez Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ios.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ jobs:
env:
scheme: ${{ 'SDKHostApp' }}
platform: ${{ 'iOS Simulator' }}
os: ${{ '16.2' }}
device: ${{ 'iPhone 13' }}
os: ${{ '18.1' }}
device: ${{ 'iPhone 16' }}
Copy link
Contributor

@ssathy2 ssathy2 Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just delete these. What happens if you don't include them?

Copy link
Contributor

@ssathy2 ssathy2 Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These params are used in the xcodebuild invocation build later in the script so that command will fail. Instead, we should update the xcodebuild command to use whatever the latest os version is. Can you make that update?

Copy link
Contributor Author

@alexianunez alexianunez Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do!

run: |
# xcrun xctrace returns via stderr, not the expected stdout (see https://developer.apple.com/forums/thread/663959)
if [ $scheme = default ]; then scheme=$(cat default); fi
Expand Down