fix(wfs-style): display on map & legend#238
Open
ibrahim-sall wants to merge 2 commits intodevelopfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts feature-type styling so that WFS-provided rgb(a) colors are respected (instead of being coerced into defaults), and updates the legend rendering to correctly display line/polygon styles.
Changes:
- Accept
rgb()/rgba()strings directly ingetStyleWebGLDefault(avoid hex conversion fallback). - Generate SVG-based legend icons for line and polygon feature types (rather than relying on well-known-name point icons).
- Use
POLYGON_LINE_COLORas a fallback for missing stroke color in the legend icons.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
src/features/navigation/layers/legends/FeatureTypeLayerLegends.tsx |
Generates SVG legend icons for line/polygon styles. |
src/constants/styles.ts |
Updates WebGL style color selection to support rgb(a) inputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If rg2a was properly passed, it was still falling back to default style. Legend was not able to display correct colors for those.
issue #190