DSERV-1291 Scorpion adapter#713
Open
pedrohr wants to merge 15 commits into
Open
Conversation
pedrohr
force-pushed
the
DSERV-1291-scorpion
branch
from
e83c943 to
cb75ec9
Compare
mingjiecn
requested changes
May 27, 2026
|
|
||
| for row in data_csv: | ||
| props = { | ||
| '_key': row['tf_ensembl'] + '_' + row['target_ensembl'] + '_' + self.LABEL, |
Collaborator
There was a problem hiding this comment.
self.LABEL has space in it, not sure if this is good for key generation. Need to replace space, or use other string for example file accession?
Collaborator
Author
There was a problem hiding this comment.
ohh great catch... will replace by underline
|
|
||
| igvf_file_accessions: | ||
| Scorpion: | ||
| - IGVFFI3035IXUW |
Collaborator
There was a problem hiding this comment.
Need to also merge in dev branch and generate new files_filesets data file for IGVF source.
Collaborator
There was a problem hiding this comment.
may need to regenerate it again since we don't know which data loading ticket goes in first...
Collaborator
Author
There was a problem hiding this comment.
the only data loading ticket ready to QA is dual-ipa, it's already generated, so I think the JSONLs in this PR are the latest
mingjiecn
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.