DSERV-1318 qvalue -> pvalue_adj#727
Open
pedrohr wants to merge 3 commits into
Open
Conversation
mingjiecn
requested changes
Jun 11, 2026
mingjiecn
left a comment
mingjiecn
left a comment
Collaborator
There was a problem hiding this comment.
- I worked on this PR(same adapter, different collection) and found an issue with biological_context: #725. Can you also fix biological_context in this collection genomic_elements_biosamples?
- Also can you fix API here: src/routers/datatypeRouters/edges/genomic_elements_biosamples.ts
- Can you remove the change in data/schemas/edges/variants_biosamples.MPRAAdapter.json since I worked on this collection in the PR I just mentioned.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.