Adds accessibility enhancements #1
Conversation
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
It looks like this PR got lost here years ago, but I found it during a UV accessibility sprint. Seems worth finishing up.
I'm going to guess that this is no longer on @mejackreed's radar or in scope for his work, but if he's interested in proceeding, he can let me know. Otherwise, I'll see if I can find a different volunteer! :-)
| this._$header.append(this._$rightOptions); | ||
|
|
||
| this._$sizeDownButton = $('<input class="btn btn-default size-down" type="button" value="-" />'); | ||
| this._$sizeDownButton = $('<input class="btn btn-default size-down" type="button" value="-" aria-label="Reduce Thumbnail Size"/>'); |
There was a problem hiding this comment.
We need to revise this to make the text i18n-friendly. I believe the way to do this is to add strings to the content element returning IGalleryComponentData in the data() method. Then the values can be overridden in the UV's getGalleryData method.
|
It also looks like there are conflicts that need to be resolved here; it may make the most sense to just close this and rebuild from the diffs. |
2 participants
No description provided.