Skip to content

Recipe #0561: Visible Text Annotation #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

triplingual
Copy link
Contributor

Closes #561

@triplingual triplingual changed the title Recipe #0561 Visible Text Annotation Recipe #0561: Visible Text Annotation Jan 6, 2025
It may matter to some viewers/clients that read the sequential order as the top-to-bottom layer order
@glenrobson
Copy link
Member

Editors are happy for this to go through to the TRC but have the following comments:

Implementation notes

  • The Presentation API states clearly that - no need to have link to prez spec
  • "Annotations referenced in items have to have the motivation value painting" - instead of "have to have" reword as must have
  • We think that painting as a value should be in quotes rather than backticked.

Example

  • Either in the use case or the example could you produce an image of what it should look like if implemented. This will help readers visulise the recipe and also for implementers to know what they are aiming for.

Related recipes

@glenrobson glenrobson added the meta: ready-for-trc Issue is ready for TRC review label Mar 18, 2025
@triplingual
Copy link
Contributor Author

Just to note that I will start tackling this 20 March.

@glenrobson glenrobson marked this pull request as ready for review March 19, 2025 22:37
@triplingual
Copy link
Contributor Author

triplingual commented Mar 20, 2025

  • no need to have link to prez spec
  • reword as must have
  • painting in quotes rather than backticked.
  • image of what it should look like if implemented
  • Remove: Image Rotation Two Ways
  • Remove: Image and Canvas with Differing Dimensions

@triplingual
Copy link
Contributor Author

Highlighting that I changed the formatting of "painting" where used as an adjective but left as backticked when used as a motivation value.

@triplingual
Copy link
Contributor Author

Changes made per IIIF/trc/issues/133 comments

@glenrobson glenrobson added meta: ready-to-merge Pull request is ready to merge into main branch and removed meta: ready-for-trc Issue is ready for TRC review meta: ready-for-editors Ready for Cookbook editor review labels Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: ready-to-merge Pull request is ready to merge into main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding visible text to a Canvas
2 participants