Skip to content

Recipe on Manifest reuse. #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 29, 2025
Merged

Recipe on Manifest reuse. #588

merged 9 commits into from
Apr 29, 2025

Conversation

robcast
Copy link
Contributor

@robcast robcast commented Mar 7, 2025

PR for recipe #464

@robcast robcast force-pushed the 0464-reuse-manifest branch from 3ae0fd2 to d9fa33a Compare March 7, 2025 16:27
@glenrobson
Copy link
Member

The cookbook editors are happy for this to go through to the TRC but request the following changes:

Implementation notes

  • Change "You have to change" to "You must change"
  • Change "You have to reproduce the requiredStatement" to something similar to you should reproduce the requiredStatement and depending on the licenses you may have to reproduce.

Example

  • Why not include more viewers? Shouldn't all of the viewers that support the simple image be included?
  • Add code highlighting for the annotation because its new and the metadata because that points to the original.

@glenrobson glenrobson added the meta: ready-for-trc Issue is ready for TRC review label Mar 18, 2025
@glenrobson glenrobson merged commit fa87b39 into master Apr 29, 2025
1 check passed
@glenrobson glenrobson deleted the 0464-reuse-manifest branch April 29, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: ready-for-trc Issue is ready for TRC review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-use of Manifests
2 participants