Skip to content

Add argument ("background-color" of type string) to specify the#55

Open
malex984 wants to merge 1 commit intoIMAGINARY:develfrom
malex984:bg
Open

Add argument ("background-color" of type string) to specify the#55
malex984 wants to merge 1 commit intoIMAGINARY:develfrom
malex984:bg

Conversation

@malex984
Copy link
Copy Markdown
Contributor

Browser-Window' background (e.g. during any refresh) instead of hardcoded white.

NOTE: transparency support is enabled despite a problem in Color library

Browser-Window' background (e.g. during any refresh) instead of hardcoded white.

NOTE: transparency support is enabled despite a problem in Color library
@porst17
Copy link
Copy Markdown
Member

porst17 commented Jan 28, 2021

Thanks for the contribution. I did a bit of cleanup and tried to make the handling of transparency easier and more consistent, especially when an alpha channel is present in the color but transparency is disabled.

Please test the feature/background-color branch. If everything is alright, I will merge it.

@malex984
Copy link
Copy Markdown
Contributor Author

Ok, it works.
Note that --transparent does NOT lead to setting alpha=0 anymore.
Now in order to get transparent window one has to specify alpha channel via background-color in addition to --transparent.

@malex984
Copy link
Copy Markdown
Contributor Author

Try: yarn start --background-color "#fff" -t vs. yarn start --background-color "#fff0" -t

@porst17
Copy link
Copy Markdown
Member

porst17 commented Jan 28, 2021

Looks good to me on macOS. If there is something suspicious, please post screenshots and describes what happens and what is supposed to happen.

@malex984
Copy link
Copy Markdown
Contributor Author

malex984 commented Jan 28, 2021

Now, (for me on linux) yarn start -t produces OPAQUE window and only --background-color "#fff0" -t leads to the requested transparent window.
Previously single -t was triggering transparency (by forcing alpha to be zero), right?
My note is about this slight change of behavior...

@porst17
Copy link
Copy Markdown
Member

porst17 commented Jan 29, 2021

Alright, well spotted!

I changed the default background color from white to #FFF0 for that matter. Please check!

@malex984
Copy link
Copy Markdown
Contributor Author

Looks good!

@porst17 porst17 force-pushed the devel branch 2 times, most recently from 855b9dd to 99fadcd Compare February 2, 2022 17:03
@porst17 porst17 force-pushed the devel branch 3 times, most recently from 601bce1 to 7cbdb68 Compare March 27, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants