Skip to content

FIX: Handle potential NaNs in the middle of the repointing files #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greglucas merged 1 commit into from
Oct 7, 2025
Merged

FIX: Handle potential NaNs in the middle of the repointing files #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions imap_data_access/webpoda.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,12 +422,16 @@ def download_repointing_data(
# NOTE: We iterate over the repointings rather than the packet times because it is
# assumed to be the shorter list (1/day vs 1000s of packets/day per apid)
for i in range(len(repointings) - 1):
pointing_start = datetime.datetime.strptime(
repointings[i]["repoint_end_utc"], "%Y-%m-%d %H:%M:%S.%f"
)
# skip i and i+1 values that are NaN
if repointings[i]["repoint_end_utc"].lower() == "nan":
# This pointing never "started"
continue
if repointings[i + 1]["repoint_end_utc"].lower() == "nan":
# Missing repointing end time, so it isn't a complete "pointing" yet.
continue
pointing_start = datetime.datetime.strptime(
repointings[i]["repoint_end_utc"], "%Y-%m-%d %H:%M:%S.%f"
)
if pointing_start > packet_times[-1]:
# This pointing is after the last packet time, so skip it
logger.debug(
Expand Down
1 change: 1 addition & 0 deletions tests/test_webpoda.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ def test_download_repointing_data(
# An unfinished repointing maneuver may have NaNs in the end times
# Make sure we can handle this and ignore it
"10,0,NaN,NaN,2024-12-03T00:00:00.000000,NaN,4\n"
"10,0,12,0,2024-12-04T00:00:00.000000,2024-12-04 00:15:00.000,5\n"
)

start_time = datetime.datetime(2024, 12, 1, 0, 0, 0)
Expand Down