Ultra l1a - energy events (apid 897) - #1865
Merged
laspsandoval merged 7 commits intoJun 30, 2025
Merged
Conversation
laspsandoval
marked this pull request as draft
June 27, 2025 22:22
laspsandoval
requested review from
demajistre,
greglucas,
lacoak21,
ndjhu and
sdhoyt
June 27, 2025 22:36
laspsandoval
force-pushed
the
ultra_l1a_tof
branch
from
June 27, 2025 23:04
0db7578 to
22cdb84
Compare
laspsandoval
marked this pull request as ready for review
June 27, 2025 23:18
greglucas
approved these changes
Jun 30, 2025
| binary = convert_to_binary_string(event_data) | ||
| # 166 bits per event | ||
| event_length = 166 if count else 0 | ||
| length = max(end for _, (_, end) in field_ranges.items()) |
Collaborator
There was a problem hiding this comment.
Suggested change
| length = max(end for _, (_, end) in field_ranges.items()) | |
| length = max(end for (_, end) in field_ranges.values()) |
laspsandoval
merged commit Jun 30, 2025
c137da9
into
IMAP-Science-Operations-Center:dev
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
This creates the data product for apid 897.
Updated Files
Testing
conftest.py
test_decom_apid_897.py
test_ultra_l1a.py