Skip to content

Ultra l1a - add more apids 898, 899, 900, 901 - #1878

Merged
laspsandoval merged 5 commits into
IMAP-Science-Operations-Center:devfrom
laspsandoval:ultra_events
Jul 1, 2025
Merged

Ultra l1a - add more apids 898, 899, 900, 901#1878
laspsandoval merged 5 commits into
IMAP-Science-Operations-Center:devfrom
laspsandoval:ultra_events

Conversation

@laspsandoval

@laspsandoval laspsandoval commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

Change Summary

Overview

Adding events apids for priority data products.

Updated Files

  • ultra_l1a
    • Added way to create xarray for new apids
  • ultra_utils
    • Added packet properties for apids
  • decom_ultra
    • Added new apids
  • imap_ultra_global_cdf_attrs.yaml
    • Added global attributes

Testing

conftest.py
test_decom_apid_898.py
test_decom_apid_899.py
test_decom_apid_900.py
test_decom_apid_901.py
test_ultra_l1a.py
external_test_data_config.py

@laspsandoval
laspsandoval marked this pull request as draft June 30, 2025 22:55
@laspsandoval laspsandoval self-assigned this Jun 30, 2025
@laspsandoval laspsandoval added Ins: Ultra Related to the IMAP-Ultra instrument Level: L1 Level 1 processing labels Jun 30, 2025
@laspsandoval laspsandoval added this to the July 2025 milestone Jun 30, 2025
@laspsandoval
laspsandoval requested a review from greglucas June 30, 2025 23:01
@laspsandoval
laspsandoval marked this pull request as ready for review June 30, 2025 23:01
@laspsandoval
laspsandoval requested review from lacoak21 and sdhoyt June 30, 2025 23:01

@greglucas greglucas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the test files can't be found on the remote, did you push them to s3?

Comment thread imap_processing/tests/external_test_data_config.py
Comment thread imap_processing/tests/ultra/unit/test_decom_apid_900.py Outdated
Comment thread imap_processing/ultra/packet_definitions/ULTRA_SCI_COMBINED.xml
@laspsandoval

Copy link
Copy Markdown
Contributor Author

Looks like the test files can't be found on the remote, did you push them to s3?

Good catch. They are now in s3.

@laspsandoval
laspsandoval requested a review from greglucas July 1, 2025 16:51

@greglucas greglucas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all those updates, I find this easier to read :)

@laspsandoval
laspsandoval merged commit 06e4d78 into IMAP-Science-Operations-Center:dev Jul 1, 2025
14 checks passed
@github-project-automation github-project-automation Bot moved this to Done in IMAP Jul 1, 2025
@laspsandoval
laspsandoval deleted the ultra_events branch July 1, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ins: Ultra Related to the IMAP-Ultra instrument Level: L1 Level 1 processing

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants