ULTRA l1a phx tof high energy

[lacoak21]

Change Summary

closes #1857

Overview

Add code to produce ultra l1a high energy cdfs

New Files

• imap_processing/tests/ultra/unit/test_decom_apid_884.py
  • Add test for new data product

Updated Files

• imap_processing/cdf/config/imap_ultra_global_cdf_attrs.yaml
  • ena tof high energy global attrs
• imap_processing/tests/ultra/unit/conftest.py
  • tof high energy and angular fixtures
• imap_processing/tests/ultra/unit/test_decom_apid_883.py
  • rename vars
• imap_processing/ultra/l0/decom_tools.py
  • adjust decomm tools to produce different tof products
• imap_processing/ultra/l0/ultra_utils.py
  • add new elements to the packetProperties named tuple to help with image decompression
• imap_processing/ultra/l1a/ultra_l1a.py
  • add code to process new product

Testing

Add testing for new data product

[Copilot]

Pull Request Overview

Adds support for two new ULTRA L1A histogram products (high angular and high energy TOF), updates the decompression tools to accept packet properties for image dimensions, and provides corresponding tests and CDF configuration.

• Extend PacketProperties to include image_panes and pixel window dimensions; define ULTRA_TOF_HIGH_ANGULAR and ULTRA_TOF_HIGH_ENERGY.
• Update process_ultra_tof and decompress_image to use the new packet properties.
• Add tests, fixtures, and CDF global attribute entries for the new data products.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
imap_processing/ultra/l1a/ultra_l1a.py	Route new APIDs through process_ultra_tof with packet props.
imap_processing/ultra/l0/ultra_utils.py	Extend PacketProperties and add new TOF_HIGH constants.
imap_processing/ultra/l0/decom_ultra.py	Update process_ultra_tof signature and coordinate setup.
imap_processing/ultra/l0/decom_tools.py	Change decompress_image to accept packet_props tuple.
imap_processing/tests/ultra/unit/conftest.py	Rename CCSDS fixtures for high angular/energy TOF.
imap_processing/tests/ultra/unit/test_decom_apid_883.py	Update references to use high angular TOF constants.
imap_processing/tests/ultra/unit/test_decom_apid_884.py	Add test for high energy TOF decompression output.
imap_processing/tests/ultra/unit/test_ultra_l1a.py	Add tests for high angular and high energy CDF generation.
imap_processing/tests/external_test_data_config.py	Register external data files for high energy TOF.
imap_processing/cdf/config/imap_ultra_global_cdf_attrs.yaml	Add global CDF attrs for high energy TOF products.

Comments suppressed due to low confidence (3)

imap_processing/cdf/config/imap_ultra_global_cdf_attrs.yaml:41

• Indentation for this block is inconsistent with the preceding block (2 spaces vs. 4); align its child keys under the same indentation level to ensure valid YAML parsing.

imap_ultra_l1a_90sensor-histogram-ena-phxtof-hi-nrg:

imap_processing/tests/ultra/unit/conftest.py:89

• The generic decom_test_data fixture expects a ccsds_path fixture, but only ccsds_path_tof_high_angular and ccsds_path_tof_high_energy are defined. Either add an alias ccsds_path = ccsds_path_tof_high_angular or update decom_test_data to lookup the correct fixture name.

def ccsds_path_tof_high_angular():

imap_processing/ultra/l0/decom_tools.py:7

• [nitpick] The parse_event import is unused in this file; remove it to avoid clutter and satisfy lint rules.

    PacketProperties,

[laspsandoval]

Nicely done! Making amazing progress!