CoDICE: consistent dimension order - #1920
Merged
bourque merged 6 commits intoJul 11, 2025
Merged
Conversation
…processing into codice-consistent-dimensions
bourque
added
Ins: CoDICE
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures consistent ordering of dimensions (time, energy, azimuth, spin) across CoDICE data products and simplifies how dimensions are defined and used.
- Replaces separate
input_dims/output_dimswith a unifieddimsconfiguration key. - Refactors data reshaping to place the counter dimension last and eliminates explicit transposition.
- Updates tests to expect arrays with the new dimension ordering.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| imap_processing/tests/codice/test_codice_l1a.py | Updated expected array shapes for low‐energy products to match the new dimension order |
| imap_processing/codice/constants.py | Replaced input_dims/output_dims entries with a single dims field |
| imap_processing/codice/codice_l1a.py | Refactored coordinate and data‐variable definitions; reshaped and extracted counters using dims |
bourque
requested review from
a team,
greglucas,
joeymukherjee,
lacoak21 and
tech3371
and removed request for
a team
July 9, 2025 21:54
greglucas
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates some CoDICE data products to have consistent ordering of dimensions (i.e. time, energy, azimuth, spin) across the CoDICE data products (and other instruments).
In making these changes, I was able to simplify how dimensions are defined and used in the code, which was a nice byproduct of this.
I also added a new unit test to ensure that the order of dimensions are correct/expected.
Closes #1504