Skip to content

Improve dagster logging when there are missing upstream dependencies - #1517

Merged
tmplummer merged 3 commits into
IMAP-Science-Operations-Center:devfrom
tmplummer:1511-improve-logging-of-missing-dependencies
Jul 22, 2026
Merged

Improve dagster logging when there are missing upstream dependencies#1517
tmplummer merged 3 commits into
IMAP-Science-Operations-Center:devfrom
tmplummer:1511-improve-logging-of-missing-dependencies

Conversation

@tmplummer

Copy link
Copy Markdown
Contributor

Improved dagster logging when there are missing upstream dependencies:

  1. Removed the dead branch (if not dependency_inputs: in run_job) — confirmed unreachable since ProcessingInputCollection has no bool/len.
  2. SPICE error now names the missing kernel types: Missing SPICE files ({spice_types}) between {start} and {end}.
  3. Generic science-file error now includes the time range: No science files were discovered between {start} and {end}....

Closes: #1511

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves observability in Dagster when a job is skipped due to missing upstream dependencies, aligning with issue #1511’s goal of making “what was missing” clearer in logs and skip reasons.

Changes:

  • Removes an unused dependency-missing branch in run_job and relies on MissingDependenciesError for skip flow.
  • Improves SPICE missing-dependency errors by including the configured SPICE kernel types in the message.
  • Improves the generic “no science files” error by including the target time window.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tmplummer
tmplummer merged commit a225a16 into IMAP-Science-Operations-Center:dev Jul 22, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this to Done in IMAP Jul 22, 2026
@tmplummer
tmplummer deleted the 1511-improve-logging-of-missing-dependencies branch July 22, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Improve logging of missing dependencies.

3 participants