A few improvements to dagster - #1544
Merged
bryan-harter merged 5 commits intoJul 31, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes several operational adjustments to the Dagster orchestration layer in sds_data_manager, aiming to increase scheduling responsiveness, improve rerun ergonomics, and provide better visibility when partitions can’t run due to missing dependencies.
Changes:
- Reduce default sensor polling intervals from 15 minutes to 5 minutes across data levels.
- Increase Batch job timeout to 5 hours and remove the “already failed with same deps” resubmission guard.
- Emit
AssetObservationmetadata when dependencies are missing, and update tests accordingly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
sds_data_manager/orchestration/config.py |
Updates sensor schedule defaults to run more frequently (5 minutes). |
sds_data_manager/orchestration/imap_job.py |
Increases Batch timeout, removes “already failed” short-circuit, and adds missing-dependency AssetObservation emissions. |
tests/orchestration/test_spacecraft.py |
Updates the missing-dependency test expectations to reflect AssetObservation behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tmplummer
approved these changes
Jul 31, 2026
tmplummer
left a comment
Contributor
There was a problem hiding this comment.
Nice improvements! Interested in responses to the Copilot comments but otherwise, looks good to me.
tech3371
approved these changes
Jul 31, 2026
tech3371
left a comment
Contributor
There was a problem hiding this comment.
Thank you for quick updates!
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
bryan-harter
merged commit Jul 31, 2026
d11d6e9
into
IMAP-Science-Operations-Center:dev
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
These are a few small unrelated changes, but related to the discussions we had about dagster the other day:
The default sensor time is now 5 minutes instead of 15. It was largely 15 just to stop the system from being overwhelmed by the initial processing efforts when dagster turned on for the first time, but 5 minutes should be plenty now
Removed the code the code that prevented failed jobs from running again with no changes. This again was something to help prevent a boatload of processing runs from occurring during the early deployment steps, but now this is causing a hassle and should just be better to re-run.
Increased the allowed batch job timeout to 5 hours. Leaving it at 1 hour caused an issues where the job completed successfully, but Dagster didn't know about it.
Perhaps the nicest one - instead of skipping an asset when we don't have the dependencies, instead we return an "AssetObservation". This keeps the little icon "grey", but it actually returns metadata about the asset at that partition. Now you can click on a grey partition for an asset, and the metadata tells you exactly what dependency it failed to retrieve.
File changes
sds_data_manager/orchestration/config.py
sds_data_manager/orchestration/imap_job.py
Testing
tests/orchestration/test_spacecraft.py