I-ALiRT - Rsync alarm - #921
Conversation
711d9d8 to
59c40ec
Compare
greglucas
left a comment
There was a problem hiding this comment.
This looks very similar to the other alarm/metric we already have, so I'm wondering if we can re-use any of that infrastructure and publish to the same "alarm" topic and just send a different message or something if that is needed.
The other thing I'm a bit unclear about here is why we need the metric/alarm at all. Could you just have the lambda triggered on every log file arrival in s3, that lambda would read the contents of the s3 object like you already have and then send a message to the topic if it found the rsync error. Then you can avoid the polling/cloudwatch alarm metrics stuff I think.
s3-log-arrival -> lambda-to-read-logs -> write-to-topic-if-error
Good ideas. Check it out now. |
64ef182 to
20e1fae
Compare
greglucas
left a comment
There was a problem hiding this comment.
Nice, I like this approach and think it ties your alarming together nicely.
ed562cf to
1e080a3
Compare
d50e78d
into
IMAP-Science-Operations-Center:dev
Change Summary
Overview
The POC would like to know if any of their logs contain an rsync failure. This PR creates a lambda and construct that searches new logs for failtures.
New Files
Testing
test_ialirt_rsync_alarm.py
Deployed and confirmed functionality