Env-driven Elasticsearch wiring + dev override (alternative to #52) - #54
Env-driven Elasticsearch wiring + dev override (alternative to #52)#54rtb-12 wants to merge 1 commit into
Conversation
Wires the noticeboard ES connection through an env_file on both Django services so the same image runs in dev (local sidecar) and prod (separate ES VM with TLS + auth) without code changes. - noticeboard/elasticsearch_stencil.env: connection-settings template - noticeboard/.gitignore + README: matches the existing per-service pattern used by postgres/ and rabbitmq/ - docker-compose.yml: env_file passthrough on intranet-server and internet-server - docker-compose.override.yml.example: opt-in dev sidecar that binds 9200 to 127.0.0.1 only and caps the JVM heap, with .gitignore for per-developer overrides Coordinates with omniport-app-noticeboard#22 (which needs to read these env vars from settings) and is an alternative shape for the inline service in omniport-docker#52.
|
Agreed on this shape — I have closed #52 in favour of it. The reasoning about keeping Elasticsearch out of the canonical compose file, and about the connection coming from the environment, both hold up. The application side already matches this PR. The security point is not hypothetical. On the deployment running #52's inline service today:
Two things this PR needs:
Happy to help with the rebase if useful. |
Summary
Why this shape
Posted as a follow-up to #52 (and an alternative shape for it) based on review feedback. Three things drove the design:
What this PR does NOT do
Test plan