Generate specific import rule if slme_individuals is overriden.
#1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If both the default module type and the module type for a specific import are set to `slme`, but the specific module has a `slme_individuals` setting that is different from the default (group-level) setting, then that module will require a specific rule to honor the module-level `slme_individuals` setting. closes #1305
matentzn
approved these changes
Nov 27, 2025
Contributor
matentzn
left a comment
matentzn
left a comment
There was a problem hiding this comment.
LGTM but these conditions require a moment to mentally execute :)
Contributor
Author
|
Hopefully the corresponding code in the new ODK Core project will be more easily readable. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If both the default module type and the module type for a specific import are set to
slme, but the specific module has aslme_individualssetting that is different from the default (group-level) setting, then that module will require a specific rule to honor the module-levelslme_individualssetting.closes #1305