Skip to content

MAINT Replace R^2 with MAE in exercise M3.02 #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 22, 2025
Merged

MAINT Replace R^2 with MAE in exercise M3.02 #830

merged 11 commits into from
Apr 22, 2025

Conversation

fritshermans
Copy link
Contributor

@fritshermans fritshermans commented Apr 19, 2025 •
edited by ArturoAmorQ
Loading

Fixes #829. Let me know your feedback!

@fritshermans fritshermans changed the title replace R^2 with MAE in exercise M3.02 WIP: replace R^2 with MAE in exercise M3.02 Apr 19, 2025
@fritshermans
Copy link
Contributor Author

I get a linter error that I don't understand. @ArturoAmorQ, could you please have a look what goes wrong here?

ArturoAmorQ
ArturoAmorQ reviewed Apr 19, 2025
View reviewed changes
Copy link
Collaborator

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this issue @fritshermans!
Here's just a quick pass to your PR.

@fritshermans fritshermans changed the title WIP: replace R^2 with MAE in exercise M3.02 replace R^2 with MAE in exercise M3.02 Apr 19, 2025
ArturoAmorQ
ArturoAmorQ reviewed Apr 22, 2025
View reviewed changes
Copy link
Collaborator

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a more in depth review. Feel free to rephrase my wording if you can simplify it.

@fritshermans
Copy link
Contributor Author

I think we're set and done 😊

@ArturoAmorQ ArturoAmorQ changed the title replace R^2 with MAE in exercise M3.02 MAINT Replace R^2 with MAE in exercise M3.02 Apr 22, 2025
ArturoAmorQ
ArturoAmorQ approved these changes Apr 22, 2025
View reviewed changes
Copy link
Collaborator

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're set and done 😊

Yes, we are! Thanks as always for your time and enthusiasm!

@ArturoAmorQ ArturoAmorQ merged commit e62b23c into INRIA:main Apr 22, 2025
3 checks passed
@fritshermans
Copy link
Contributor Author

It's a pleasure!

@fritshermans fritshermans deleted the mae branch April 22, 2025 15:12
github-actions bot pushed a commit that referenced this pull request Apr 22, 2025
@ArturoAmorQ
[ci skip] MAINT Replace R^2 with MAE in exercise M3.02 (#830) e62b23c
bbf1d4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturoAmorQ ArturoAmorQ ArturoAmorQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use MAE isntead of R2 in Exercise M3.02
2 participants
@fritshermans @ArturoAmorQ