build(deps): upgrade JavaFX from 26-ea+6 to 27-ea+16 in spoon-visualisation#6728
Open
MartinWitt wants to merge 6 commits into
Open
build(deps): upgrade JavaFX from 26-ea+6 to 27-ea+16 in spoon-visualisation#6728MartinWitt wants to merge 6 commits into
MartinWitt wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the JavaFX dependency used by the spoon-visualisation module, and (additionally) changes the module’s parent POM version.
Changes:
- Bump JavaFX from
26-ea+6to27-ea+16via thejfx.versionproperty. - Update the
spoon-pomparent version from11.1.0to11.3.1-beta-8.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <groupId>fr.inria.gforge.spoon</groupId> | ||
| <artifactId>spoon-pom</artifactId> | ||
| <version>11.1.0</version> | ||
| <version>11.3.1-beta-8</version> |
MartinWitt
changed the title
…sation JavaFX 27-ea moved module-info.class to platform-specific JARs only. Add OS-detection profiles and platform classifier to dependencies so the compiler finds the JPMS modules on all platforms (win/mac/linux).
…sation JavaFX 27-ea removed module-info.class from the base JAR. With maven-compiler-plugin 3.15.0 (from updated parent POM), this causes 'module not found' errors. Fix: remove module-info.java and set useModulePath=false in the compiler plugin, running the project as a plain classpath app — which it already is at runtime via the shade JAR.
Collaborator
|
@MartinWitt that would be so cool if you get this one green! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…