Fix/spice data#286
Merged
Merged
Conversation
…ss platforms and integrate with .NET packaging
…n for .NET packaging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for the CLPS APM1 spacecraft clock and orientation kernels, ensures correct time conversions (notably UTC to TDB) throughout the codebase, and adds comprehensive tests for the new kernel data. It also updates project metadata to reflect the new version and includes new kernel files in the test suite. The most important changes are summarized below:
Support for CLPS APM1 kernels and data:
clps_to2ab_apm1_v02.tscandclps_to2ab_apm1_cru_rec_240108_240118_v02.bc) to the test data and ensured they are always copied to the output directory for tests. ([IO.Astrodynamics.Net/IO.Astrodynamics.Tests/IO.Astrodynamics.Tests.csprojR155-R162](https://github.com/IO-Aerospace-software-engineering/Astrodynamics/pull/286/files#diff-003179c8b9e25332b0a7474b12bd28359ba7ee9638157d1fc68e81db2d1c3bdeR155-R162))ClpsDataPathinConstants.csto reference the CLPS data directory. ([IO.Astrodynamics.Net/IO.Astrodynamics.Tests/Constants.csR12](https://github.com/IO-Aerospace-software-engineering/Astrodynamics/pull/286/files#diff-8279102348faade2c2e57476de15cbda513083a7ce1642a057dd05508045bb21R12))Time conversion and data mapping fixes:
ProfilesConfiguration.csto consistently useToTDB()when calculating time offsets from J2000, ensuring correct time frame usage for state vectors, orientations, windows, and orbital elements. ([[1]](https://github.com/IO-Aerospace-software-engineering/Astrodynamics/pull/286/files#diff-d3bf4a43fd72873ca7312e292f1ff5c4462d361549ebb2c4b5d2f30f3ff2c51fL46-R46),[[2]](https://github.com/IO-Aerospace-software-engineering/Astrodynamics/pull/286/files#diff-d3bf4a43fd72873ca7312e292f1ff5c4462d361549ebb2c4b5d2f30f3ff2c51fL58-R64),[[3]](https://github.com/IO-Aerospace-software-engineering/Astrodynamics/pull/286/files#diff-d3bf4a43fd72873ca7312e292f1ff5c4462d361549ebb2c4b5d2f30f3ff2c51fL104-R104))Testing and validation:
SpiceApiTest.csto validate reading orientation data from the CLPS APM1 CK kernel, both for UTC and TDB time windows. These tests check for correct time conversions, valid quaternion normalization, and proper kernel loading/unloading. ([IO.Astrodynamics.Net/IO.Astrodynamics.Tests/SpiceApiTest.csR1026-R1127](https://github.com/IO-Aerospace-software-engineering/Astrodynamics/pull/286/files#diff-26b39290bdb4cafe9c5ca5fffd49d309b3b57cb1cf887d8c7f1734a3e2a7029dR1026-R1127))Configuration and permissions:
.claude/settings.local.jsonto allow running the new CK kernel extraction commands via bash, supporting the new test scenarios. ([IO.Astrodynamics.Net/.claude/settings.local.jsonL44-R46](https://github.com/IO-Aerospace-software-engineering/Astrodynamics/pull/286/files#diff-43ab4f811a53348422097707008317d95fd95257f135452d5b567eeb1b44941aL44-R46))Versioning and packaging:
IO.Astrodynamics.CLI.csprojandIO.Astrodynamics.nuspecto0.8.4.3-previewand8.4.3-previewrespectively, reflecting the new features and fixes. ([[1]](https://github.com/IO-Aerospace-software-engineering/Astrodynamics/pull/286/files#diff-d4c3c86f426ad9db1321379dc7b37ba13f6b8132586bc03250e7678de2fd9372L12-R12),[[2]](https://github.com/IO-Aerospace-software-engineering/Astrodynamics/pull/286/files#diff-5c63e65b5e8c471dd75804cea58cb32d0f983dbc07fd7278c982128f577d49adL7-R7))