Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IONOS: fix(Viewer): fix image load error with number folder #23

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

fracado
Copy link

@fracado fracado commented Feb 10, 2025

Fixes a bug that a file cannot be opened if it is on the same level as a (shared) folder with a name that only contains numbers.
(Only happens with Firefox.)

Note: Very similar to nextcloud/photos#783

Copy link

@bromiesTM bromiesTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review ok
I'd wait for a response/agreement to this thread before merging
nextcloud#2736 (comment)

@fracado
Copy link
Author

fracado commented Feb 13, 2025

review ok I'd wait for a response/agreement to this thread before merging nextcloud#2736 (comment)

As nextcloud#2735 has been merged now, I'd suggest we can safely merge this one as well.

@fracado fracado merged commit cab07a7 into ionos-dev Feb 13, 2025
7 of 23 checks passed
@fracado fracado deleted the fb/dev/fix-viewer-number-load-error branch February 13, 2025 13:22
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants