Update GetAllNotificationsByUser use case #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekraffmiller
changed the title
ekraffmiller
added
GREI Re-arch
g-saracca
approved these changes
Oct 9, 2025
| offset?: number | ||
| ): Promise<Notification[]> { | ||
| const queryParams = inAppNotificationFormat ? { inAppNotificationFormat: 'true' } : undefined | ||
| const queryParams: Record<string, string | number> = {} |
There was a problem hiding this comment.
I think here using new URLSearchParams is more robust. As we did in getCollectionItems and getMyDataCollectionItems
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updates the GetAllNotificationsByUser use case to allow results to return only unread messages. Also adds parameters for pagination (limit and offset).
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Suggestions on how to test this:
review code and tests. Note that this has a waiting tag. Should not be merged until the related Dataverse PR is merged.
Is there a release notes or changelog update needed for this change?:
Yes, changelog updated.
Additional documentation: