-
Notifications
You must be signed in to change notification settings - Fork 20
add use cases for creating datasets based on dataset type including linked metadata blocks #845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Hi Phil, thanks for adding this use case! Could you solve the conflicts and fix and add some tests to the features, logs here, you made changes on You could run cypress locally |
@pdurbin might be good to update this branch with develop, after doing that I recommend deleting the |
Conflicts: package-lock.json package.json
9edcfda
to
6b30968
Compare
The DropdownButtonItem disabled property depends on it.
What this PR does / why we need it:
Which issue(s) this PR closes:
Special notes for your reviewer:
In the dropdown menus I think we should make the list dynamic, based on available dataset types (I added a TODO).
Suggestions on how to test this:
I was testing the review type by adding it and linking it to the citation metadata block:
curl -H "X-Dataverse-key:$API_TOKEN" -H "Content-Type: application/json" "http://localhost:8080/api/datasets/datasetTypes" -X POST -d '{"name":"review","linkedMetadataBlocks":["geospatial"]}'
However, not that the geospatial block doesn't have any displayOnCreate fields, so you won't see them on create.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes, when enabled, you'll see "New Review" in the header and "add data" dropdowns:
Is there a release notes or changelog update needed for this change?:
If we enable it, yes. See TODO above
Additional documentation:
None.