Skip to content

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Sep 30, 2025

What this PR does / why we need it:

  • create a dataset based on a dataset type (only "review" is supported, for now)
  • when creating dataset or editing dataset metadata, show additional displayOnCreate fields based on the dataset type

Which issue(s) this PR closes:

Special notes for your reviewer:

In the dropdown menus I think we should make the list dynamic, based on available dataset types (I added a TODO).

Suggestions on how to test this:

I was testing the review type by adding it and linking it to the citation metadata block:

curl -H "X-Dataverse-key:$API_TOKEN" -H "Content-Type: application/json" "http://localhost:8080/api/datasets/datasetTypes" -X POST -d '{"name":"review","linkedMetadataBlocks":["geospatial"]}'

However, not that the geospatial block doesn't have any displayOnCreate fields, so you won't see them on create.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Yes, when enabled, you'll see "New Review" in the header and "add data" dropdowns:

Screenshot 2025-09-30 at 5 09 47 PM Screenshot 2025-09-30 at 5 10 06 PM

Is there a release notes or changelog update needed for this change?:

If we enable it, yes. See TODO above

Additional documentation:

None.

@pdurbin pdurbin moved this to Ready for Review ⏩ in IQSS Dataverse Project Sep 30, 2025
@github-actions github-actions bot added FY26 Sprint 6 FY26 Sprint 6 (2025-09-10 - 2025-09-24) FY26 Sprint 7 FY26 Sprint 7 (2025-09-24 - 2025-10-08) labels Sep 30, 2025
@pdurbin pdurbin added the GREI Re-arch GREI re-architecture-related label Sep 30, 2025
@coveralls
Copy link

coveralls commented Sep 30, 2025

Coverage Status

coverage: 97.223% (+0.07%) from 97.156%
when pulling 574f01e on 821-datasetTypes
into 905d610 on develop.

@ChengShi-1
Copy link
Contributor

ChengShi-1 commented Oct 1, 2025

Hi Phil, thanks for adding this use case!

Could you solve the conflicts and fix and add some tests to the features, logs here, you made changes on JSDatasetMapper.ts, so mock data should include a dataType, then you could add test on it as well.

You could run cypress locally npm run cy:open-e2e or npm run cy:open-unit, more details in development guide. After running it, the cypress will open its own dashboard and a browser, you could navigate to the file in its dashboard. I always make sure all test cases pass locally, and for every file I changed, I search for the test file to check if all test pass there.

@g-saracca
Copy link
Contributor

@pdurbin might be good to update this branch with develop, after doing that I recommend deleting the node_modules folder both in the root project and design system and then running the npm i command again.
In this PR we update node version to 22 and lot of other deps so it might be good to do a fresh install deleting node_modules folder.

@pdurbin pdurbin moved this from Ready for Review ⏩ to In Progress 💻 in IQSS Dataverse Project Oct 6, 2025
@pdurbin pdurbin self-assigned this Oct 6, 2025
@cmbz cmbz added the FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) label Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 6 FY26 Sprint 6 (2025-09-10 - 2025-09-24) FY26 Sprint 7 FY26 Sprint 7 (2025-09-24 - 2025-10-08) FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) GREI Re-arch GREI re-architecture-related

Projects

Status: In Progress 💻

Development

Successfully merging this pull request may close these issues.

Allow "review" dataset type to be created, when configured

5 participants