Contact Owner and Share buttons in File page #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
GREI Re-arch
g-saracca
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the Contact Owner and Share button in the file page.
Which issue(s) this PR closes:
Special notes for your reviewer:
Reusing same Contact and Share components used in Dataset & Collection pages.
Just change the rendering condition of the Share button a little bit. Before it was checking if the dataset version wasn't deaccessioned or the user has edit permissions, now only renders the button if it's not deaccessioned as JSF is doing.
Suggestions on how to test this:
This is just reusing the same components used in dataset and collection page for sharing and contacting owners.
So maybe same checks as in dataset and collection pages.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes, adds this buttons in File Page.
Is there a release notes or changelog update needed for this change?:
Yes, added in CHANGELOG.
Additional documentation: