Improve DataCiteXML robustness w.r.t. ROR #11782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofahimIQSS
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
stevenwinship
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS Dataverse Project
stevenwinship
approved these changes
Sep 3, 2025
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
pdurbin
moved this from Ready for QA ⏩
to Reviewed but Frozen ❄️
in IQSS Dataverse Project
cmbz
added
FY26 Sprint 6
pdurbin
moved this from Reviewed but behind develop ⬅️
to Ready for QA ⏩
in IQSS Dataverse Project
|
looks good from my end - merging |
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: In adapting to ROR v2 API, I hit a potential bug if the Ext. vocab configuration includes a whole array of names from ROR rather than a single one (as a JsonString) as with ROR v1. While this is something that can be handled by changing the configuration, it makes sense to have a check in the Dataverse code as well.
Which issue(s) this PR closes:
Special notes for your reviewer: The PR also prints a stack trace when an export fails - hard to tell what went wrong otherwise.
Suggestions on how to test this: Use the ORCID/ROR config in gdcc/dataverse-external-vocab-support#46 and verify that you see a failure to export the DataCite XML when an author affiliation is used (e.g. "QDR"). With the fix, the DataCite xml should be generated and the ROR id included in it as the author affiliation (the org name will not be included).
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: no? fixes an issue that would only be possible with the ROR v2 api
Additional documentation: