Skip to content

Conversation

GPortas
Copy link
Contributor

@GPortas GPortas commented Sep 29, 2025

What this PR does / why we need it:

Endpoint: notifications/all

Enhancements:

  • When the query parameter inAppNotificationFormat=true is set:

    • Notifications of types:

      • REQUESTFILEACCESS
      • REQUESTEDFILEACCESS
      • GRANTFILEACCESS
      • REJECTFILEACCESS

    now return both the dataset display name and dataset persistent identifier.

Notifications of type DATASETMENTIONED now return a formatted JSON in the additionalInfo field when this field contains a valid persisted JSON string, instead of a raw JSON string.

Which issue(s) this PR closes:

Suggestions on how to test this:

  • Visual inspection of the new added properties, and related unit test cases
  • Test generating the updated notification types and test the endpoint for InApp notifications by calling:

curl -H "X-Dataverse-key:$API_TOKEN" "$SERVER_URL/api/notifications/all?inAppNotificationFormat=true"
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
Yes, attached

@coveralls
Copy link

coveralls commented Sep 29, 2025

Coverage Status

coverage: 23.55% (+0.009%) from 23.541%
when pulling 2d0d062 on 11804-notifs-api-ext
into 08b9ec6 on develop.

This comment has been minimized.

@GPortas GPortas marked this pull request as ready for review September 29, 2025 15:05
@GPortas GPortas moved this to Ready for Review ⏩ in IQSS Dataverse Project Sep 29, 2025

This comment has been minimized.

@GPortas GPortas added Size: 3 A percentage of a sprint. 2.1 hours. SPA These changes are required for the Dataverse SPA GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 3 SPA.Q3.2025.6 Account: Notifications labels Sep 29, 2025

This comment has been minimized.

1 similar comment

This comment has been minimized.

This comment has been minimized.

@ekraffmiller
Copy link
Contributor

Hi @GPortas , I tested this with the frontend, and I found some issues in the response data.

For GRANTFILEACCESS and REJECTFILEACCESS
notifications, it's returning objectDeleted: true, rather than the datasetDisplayName and datasetPersistentId. For example for GRANTFILEACCESS, the notification coming from the API:


{

displayAsRead: true


id: 9


objectDeleted: true


sentTimestamp: "2025-10-03T00:23:32Z"


type: "GRANTFILEACCESS"

}


For REQUESTEDFILEACCESS, it's not returning the full datasetPersistentId.
For example it is returning:
datasetPersistentIdentifier: "FK2/1LPTK4"
when it should be:
datasetPersistentIdentifier: ”doi:10.5072/FK2/1LPTK4"




@GPortas GPortas self-assigned this Oct 8, 2025
@GPortas GPortas moved this from Ready for Review ⏩ to In Progress 💻 in IQSS Dataverse Project Oct 8, 2025
Copy link

github-actions bot commented Oct 8, 2025

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:11804-notifs-api-ext
ghcr.io/gdcc/configbaker:11804-notifs-api-ext

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@cmbz cmbz added the FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) label Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q3.2025.6 Account: Notifications SPA These changes are required for the Dataverse SPA

Projects

Status: In Progress 💻

Development

Successfully merging this pull request may close these issues.

Update Notifications API response values

4 participants