-
Notifications
You must be signed in to change notification settings - Fork 530
Notifications API fixes for In-App #11851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @GPortas , I tested this with the frontend, and I found some issues in the response data. For GRANTFILEACCESS and REJECTFILEACCESS notifications, it's returning objectDeleted: true, rather than the datasetDisplayName and datasetPersistentId. For example for GRANTFILEACCESS, the notification coming from the API:
For REQUESTEDFILEACCESS, it's not returning the full datasetPersistentId. |
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
What this PR does / why we need it:
Endpoint:
notifications/all
Enhancements:
When the query parameter
inAppNotificationFormat=true
is set:Notifications of types:
REQUESTFILEACCESS
REQUESTEDFILEACCESS
GRANTFILEACCESS
REJECTFILEACCESS
now return both the dataset display name and dataset persistent identifier.
Notifications of type
DATASETMENTIONED
now return a formatted JSON in theadditionalInfo
field when this field contains a valid persisted JSON string, instead of a raw JSON string.Which issue(s) this PR closes:
Suggestions on how to test this:
curl -H "X-Dataverse-key:$API_TOKEN" "$SERVER_URL/api/notifications/all?inAppNotificationFormat=true"
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
Yes, attached