DD-2023 Missing body entity with Pre-Workflow POST of AuthorizedExter… #11895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofahimIQSS
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DD-2023 Missing body entity with Pre-Workflow POST of AuthorizedExternalStep
What this PR does / why we need it:
We are not able to publish a dataset created on WEB-UI one of the DANS DataStations using IQSS release 6.7.1.
When Publish action is started, the dataset will be locked with a Workflow.
DANS microservices should get an http message from IQSS
AuthorizedExternalStepwithdataset’s information but the message is empty and caused process failure.Which issue(s) this PR closes:
https://drivenbydata.atlassian.net/browse/DD-2023
Special notes for your reviewer:
The added entity-body in source file
AuthorizedExternalStep.javais comparable withHttpSendReceiveClientStep.javain the same package.Suggestions on how to test this:
Add a unittest
src/test/java/edu/harvard/iq/dataverse/workflow/internalspi/AuthorizedExternalStepTest.javaDoes this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: