Storage quotas patch: Minor/cosmetic improvements #11988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the rollout of collection quotas at HDV. It disables the "Upload a Folder", DropBox and Globus upload buttons on the upload page when the quotas are maxed out (in addition to disabling the standard upload). To be clear, an attempt to upload anything via webloader, etc. is not going to work once the quota is reached; but there is no point in showing these options as available either. The remaining quota is made more prominent - in red - as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This was made based on the experience with setting up collection quotas at HDV. It disables the "Upload a Folder", DropBox and Globus upload buttons on the upload page when the quotas are maxed out (in addition to disabling the standard upload). To be clear, an attempt to upload anything via webloader, etc. is not going to work once the quota is reached; but there is no point in showing these options as available either. The remaining quota display is made more prominent - in red - as well.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Upload a few files in a dataset. Enable storage quotas, and configure a storage quota on the parent collection such that it is smaller than the storage size of the test dataset. With this build deployed, this should block all the upload buttons on the Add Files page. (you'll need an S3 volume w/ direct upload enabled to see the webloader/"Upload a Folder" button; you'll need a Globus volume to see the "Upload with Globus" button, etc.)
The "Storage quota: 0 bytes remaining" should be displayed in red on the Add Files page.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: