fix: remove deprecated navigator.platform and unused variables #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove deprecated navigator.platform API usage - Remove unused variables: browserLanguage, platform, timeZoneOffset - Clean up dead code in taxReturnCreate.ts and PreviewTaxReturns.tsx These variables were declared but never used in the request bodies, creating unnecessary code clutter. The navigator.platform API is also deprecated according to MDN documentation. This change improves code maintainability and eliminates deprecation warnings without affecting functionality.
|
Was this AI-generated? |
GreenRoadBen
suggested changes
Jun 6, 2025
GreenRoadBen
left a comment
GreenRoadBen
left a comment
There was a problem hiding this comment.
The files being changed do not correspond to the intent as described in the PR initial comment.
Best course of action is to make a new branch from current main and make the changes anew.
@tredondo in #9 (comment)
May be correct.
|
@tredondo @GreenRoadBen looks like the deceptively large file diff that now shows was caused by the force push to main from the maintainer after this PR was opened. If you look at the commits, you can see the PR author's changes do appear to match their description. Dropping the initial commit and rebasing the other one should address this discrepancy without necessitating a separate branch or new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes deprecated API usage and cleans up unused variables in the codebase.
Changes Made
navigator.platformAPI usagebrowserLanguage,platform,timeZoneOffsettaxReturnCreate.tsandPreviewTaxReturns.tsxWhy This Change?
These variables were declared but never used in the request bodies, creating unnecessary code clutter. The
navigator.platformAPI is also deprecated according to MDN documentation.Impact
Testing
Since these variables were never used, removing them has no functional impact. The TypeScript compiler should validate that no references to these variables remain.