Skip to content

Always generate row names #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MichaelChirico
Copy link

Closes #175

This PR is currently incomplete -- checking it in as a first step towards a solution.

Basically I'm suggesting {repr} override the default dimension printing (the style of which is more-or-less unchanged in base R for "forever": https://github.com/r-devel/r-svn/blame/main/src/main/printarray.c) in favor of defaulting to just applying the column/row number.

  • If that looks good to you, there's a little bit of clean-up we can do where other parts in the code refer to rownames() possibly being empty that are now redundant.
  • Otherwise, let's discuss alternative approaches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnamed matrices resulting misleadingly-labelled outputs
1 participant